Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update / README and template changes #342

Merged
merged 11 commits into from
Apr 25, 2023
Merged

Update / README and template changes #342

merged 11 commits into from
Apr 25, 2023

Conversation

ImreSamu
Copy link
Member

@ImreSamu ImreSamu commented Apr 22, 2023 •
edited
Loading

Changes/Proposals:

  • improve README ( with security, troubleshooting, .. )
  • improve LABEL
  • Alpine: add BASE_IMAGE ( using with other base images )
  • Alpine: extend testing ( now it is similar than the -master )
  • make update ( regenerate docker files from templates )

EDIT:

  • adding cunit-dev;git to the alpine build

removing this warnings:

checking for CUNIT... no
configure: WARNING: could not locate CUnit required for unit tests
...
/usr/bin/perl ./utils/repo_revision.pl
Can't determine revision: no git executable found

EDIT2:

  • in *-master template : fix lto and add cunit

@ImreSamu ImreSamu marked this pull request as ready for review April 22, 2023 18:36
@ImreSamu
Copy link
Member Author

Ready for review.

phillipross
phillipross approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome elaboration in the docs, thank you!
This looks good to me, is it ready for merge?

@ImreSamu
Copy link
Member Author

Thanks for reviewing! Yes, it's ready to merge.

@phillipross phillipross merged commit b50183f into postgis:master Apr 25, 2023
@ImreSamu ImreSamu deleted the update_2022mar31 branch April 25, 2023 17:40
submarcos pushed a commit to submarcos/docker-postgis that referenced this pull request May 23, 2023
@ImreSamu @submarcos
Update / README and template changes (postgis#342)
d9dd7bf 
* extend README with practical advices

* update LABEL

* update LABEL, add BASE_IMAGE; improve testing code

* small edits

* make update

* fix alpine template

* make update

* add cunit-dev;git to alpine

* make update

* master: fix lto; and add cunit

* make update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipross phillipross phillipross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImreSamu @phillipross