Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in master dockerfiles #332

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

Alexandre27
Copy link
Contributor

When using an old gdal version, the build failed due to a cmake error. After inspection, I realized that it wasn't running the autogen script due to a typo in the if condition.

@ImreSamu
Copy link
Member

Hi @Alexandre27 !
Thanks for opening this pull request!

I realized that it wasn't running the autogen script due to a typo in the if condition.

It's a valid concern, and probably my typo; I apologize.

Please:

  • Also update the original Dockerfile.master.template
  • Run make update ( regenerate the new Dockerfiles from template )
  • Check the changes
  • Commit the changes

I accept the fix in advance, but the final merge is up to @phillipross.

@Alexandre27
Copy link
Contributor Author

Hi @ImreSamu!
Sorry, but didn't notice the template file. Fixed and updated.

Copy link
Member

@ImreSamu ImreSamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Looks OK.

@phillipross phillipross merged commit 4b53c95 into postgis:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants