fix: --fix-lockfile should not remove the fields like hasBin and depr… #6784

SoonIter · 2023-07-09T18:42:42Z

…ecated

SoonIter · 2023-07-10T04:11:35Z

@zkochan
'deprecated' field can only be regenerated by fully resolution to registry from packageManifest

pnpm/pkg-manager/package-requester/src/packageRequester.ts

Line 183 in e4ef6f4

    
           if (!skipResolution || options.skipFetch === true || Boolean(pkgId?.startsWith('file:')) || wantedDependency.optional === true) {

However, 'hasBin' and 'prepare' can be regenerated from pkg here

pnpm/pkg-manager/resolve-dependencies/src/resolveDependencies.ts

Line 1234 in e4ef6f4

    
           hasBin = Boolean((pkg.bin && !(pkg.bin === '' || Object.keys(pkg.bin).length === 0)) ?? pkg.directories?.bin)

Maybe I can preserve the deprecated field here and it is a workaround

pnpm/pkg-manager/core/src/install/index.ts

Lines 959 to 973 in a53ef4d

    
           // Ignore some fields when fixing lockfile, so these fields can be regenerated 
        
           // and make sure it's up to date 
        
           if ( 
        
             opts.fixLockfile && 
        
             (ctx.wantedLockfile.packages != null) && 
        
             !isEmpty(ctx.wantedLockfile.packages) 
        
           ) { 
        
             ctx.wantedLockfile.packages = mapValues(({ dependencies, optionalDependencies, resolution }) => ({ 
        
               // These fields are needed to avoid losing information of the locked dependencies if these fields are not broken 
        
               // If these fields are broken, they will also be regenerated 
        
               dependencies, 
        
               optionalDependencies, 
        
               resolution, 
        
             }), ctx.wantedLockfile.packages) 
        
           }

i think let '--fix-lockfile' the same as 'BROKEN_LOCKFILE' behavior is acceptable.

PoomSmart · 2024-11-27T06:54:58Z

Any ETA for this PR to be merged?

SoonIter · 2024-12-02T08:07:31Z

I'm running out of time and won't be able to update this PR. another PR is welcome. If anyone intends to regenerate these lockfile fields, they can give "pnpm i --lockfile-only" a try

SoonIter requested a review from zkochan as a code owner July 9, 2023 18:42

fix: --fix-lockfile should not remove the fields like hasBin and depr…

0be9fc5

…ecated

SoonIter force-pushed the fix/fix-lockfile-arg branch from 8268761 to 0be9fc5 Compare July 9, 2023 19:53

fix: fix-lockfile

d1cd9e2

fix: fix-lockfile

15e42be

SoonIter force-pushed the fix/fix-lockfile-arg branch from b286922 to 15e42be Compare July 11, 2023 07:05

Merge branch 'main' into fix/fix-lockfile-arg

2064cce

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: --fix-lockfile should not remove the fields like hasBin and depr… #6784

fix: --fix-lockfile should not remove the fields like hasBin and depr… #6784

SoonIter commented Jul 9, 2023

SoonIter commented Jul 10, 2023

PoomSmart commented Nov 27, 2024

SoonIter commented Dec 2, 2024 •

edited

Loading

fix: --fix-lockfile should not remove the fields like hasBin and depr… #6784

Are you sure you want to change the base?

fix: --fix-lockfile should not remove the fields like hasBin and depr… #6784

Conversation

SoonIter commented Jul 9, 2023

SoonIter commented Jul 10, 2023

PoomSmart commented Nov 27, 2024

SoonIter commented Dec 2, 2024 • edited Loading

SoonIter commented Dec 2, 2024 •

edited

Loading