Skip to content

Refactor autoshapes to use shape.label for vline/hline/vrect/hrect #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nochinxx wants to merge 17 commits into
base: main
Choose a base branch
from
+475 −39
Draft

Refactor autoshapes to use shape.label for vline/hline/vrect/hrect #5444

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b6d9a05
refactor/autoshapes-use-shape-label: created helper _coerce_shape_lab…
nochinxx Nov 17, 2025
b5b325e
BaseFigure.add_vline: coerce legacy annotation_* kwargs into shape.la…
nochinxx Nov 17, 2025
a8bf7be
-chore(autoshapes): add legacy→label shim (non-destructive) and line-…
nochinxx Nov 17, 2025
3e01187
chore: ignore generated remoteEntry JS bundles
nochinxx Nov 17, 2025
a4c525a
Merge branch 'main' into refactor/autoshapes-use-shape-label
nochinxx Nov 18, 2025
b21ed6e
Merge pull request #1 from lilyMaung/refactor/autoshapes-use-shape-label
nochinxx Nov 20, 2025
1a677ff
Merge branch 'plotly:main' into main
LeoPrissberg Nov 21, 2025
003b020
Merge branch 'plotly:main' into refactor/autoshapes-use-shape-label
lilyMaung Nov 26, 2025
0ba47b1
preserve legacy annotation for add_vline
chanlii Dec 2, 2025
b46f886
refactor (add_vrect): Create a single labeled shape and map legacy an…
chanlii Dec 2, 2025
22ee227
Merge branch 'plotly:main' into main
lilyMaung Dec 4, 2025
a6898b3
Merge branch 'plotly:main' into refactor/add_vrect
chanlii Dec 5, 2025
163067f
Merge branch 'main' into refactor/add_vrect
chanlii Dec 5, 2025
3975cf1
Merge pull request #3 from lilyMaung/refactor/add_vrect
nochinxx Dec 5, 2025
a8dbb7c
Migrate add_hrect from annotation to shape/label
chanlii Dec 6, 2025
eab6069
Merge pull request #4 from lilyMaung/refactor/add_hrect
nochinxx Dec 6, 2025
515b4e4
refactored and change the comments of hline,vrect,hrect
nochinxx Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BaseFigure.add_vline: coerce legacy annotation_* kwargs into shape.la… 
…bel (prep for shape.label refactor)
  • Loading branch information
@nochinxx
nochinxx committed Nov 17, 2025
commit b5b325e8931dc8f0d93338ef535efff7616c527b
2 changes: 2 additions & 0 deletions plotly/basedatatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4223,6 +4223,8 @@ def add_vline(
annotation=None,
**kwargs,
):
# NEW (Step 2): translate legacy annotation_* → label (non-destructive; warns if used)
kwargs = _coerce_shape_label_from_legacy_annotation_kwargs(kwargs)
self._process_multiple_axis_spanning_shapes(
dict(type="line", x0=x, x1=x, y0=0, y1=1),
row,
Expand Down