Skip to content

Fix GeoPandas dataset compatibility for naturalearth_cities #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AliAbouelazm wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −2
Open

Fix GeoPandas dataset compatibility for naturalearth_cities #5420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f31155a
Fix GeoPandas dataset compatibility for naturalearth_cities
Nov 16, 2025
9ec9a45
Docs: avoid network in GeoPandas examples; use in-memory fallback Geo…
Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix GeoPandas dataset compatibility for naturalearth_cities 
Update documentation examples to work with both GeoPandas < 1.0 and >= 1.0.
The old gpd.datasets.get_path() method was removed in GeoPandas 1.0.
This fix:
- Tries the old method first (for backward compatibility)
- Falls back to geodatasets package for GeoPandas >= 1.0
- Includes a URL fallback if geodatasets is not available

Fixes #4778
  • Loading branch information
Ali Abouelazm authored and Ali Abouelazm committed Nov 16, 2025
commit f31155a954ad565c0ab1503876854cd9baaa50b0
13 changes: 12 additions & 1 deletion doc/python/scatter-plots-on-maps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,18 @@ fig.show()
import plotly.express as px
import geopandas as gpd

geo_df = gpd.read_file(gpd.datasets.get_path('naturalearth_cities'))
# Handle both old and new GeoPandas versions
try:
# Try the old method (GeoPandas < 1.0)
geo_df = gpd.read_file(gpd.datasets.get_path('naturalearth_cities'))
except (AttributeError, ValueError):
# Use the new method (GeoPandas >= 1.0)
try:
import geodatasets
geo_df = gpd.read_file(geodatasets.get_path('naturalearth.cities'))
Comment on lines +84 to +85
Copy link
Member

@LiamConnors LiamConnors Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dataset doesn't currently exist on geodatasets, so this will never be successful even with geopandas >=1.0

except ImportError:
# Fallback: use a direct URL if geodatasets is not available
geo_df = gpd.read_file('https://raw.githubusercontent.com/geopandas/geopandas/main/tests/data/naturalearth_cities.geojson')

px.set_mapbox_access_token(open(".mapbox_token").read())
fig = px.scatter_geo(geo_df,
Expand Down
13 changes: 12 additions & 1 deletion doc/python/tile-scatter-maps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,18 @@ fig.show()
import plotly.express as px
import geopandas as gpd

geo_df = gpd.read_file(gpd.datasets.get_path('naturalearth_cities'))
# Handle both old and new GeoPandas versions
try:
# Try the old method (GeoPandas < 1.0)
geo_df = gpd.read_file(gpd.datasets.get_path('naturalearth_cities'))
except (AttributeError, ValueError):
# Use the new method (GeoPandas >= 1.0)
try:
import geodatasets
geo_df = gpd.read_file(geodatasets.get_path('naturalearth.cities'))
except ImportError:
# Fallback: use a direct URL if geodatasets is not available
geo_df = gpd.read_file('https://raw.githubusercontent.com/geopandas/geopandas/main/tests/data/naturalearth_cities.geojson')

fig = px.scatter_map(geo_df,
lat=geo_df.geometry.y,
Expand Down