Skip to content

Add datetime support to _mean() #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-ad wants to merge 4 commits into
base: main
Choose a base branch
from
+71 −1
Open

Add datetime support to _mean() #5368

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5a53af
Allow for vlines on datetime axes with annotations by extending _mean…
m-ad Oct 8, 2025
8a46c4c
remove type hints for python 3.8 compatibility
m-ad Oct 8, 2025
ff88033
revert an accidental change not related to this feature to keep the P…
m-ad Oct 8, 2025
7944e0f
Merge branch 'main' into fix_add_vline_with_annotation_to_datetime_axis
emilykl Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert an accidental change not related to this feature to keep the P… 
…R clean
  • Loading branch information
@m-ad
m-ad committed Oct 8, 2025
commit ff88033006d8daba631df6033fcf68d2f11e19bc
3 changes: 0 additions & 3 deletions plotly/shapeannotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ def axis_spanning_shape_annotation(annotation, shape_type, shape_args, kwargs):
annotation_position = None
if "annotation_position" in kwargs.keys():
annotation_position = kwargs["annotation_position"]
shape_dict = {}
if shape_type.endswith("line"):
shape_dict = annotation_params_for_line(
shape_type, shape_args, annotation_position
Expand All @@ -243,8 +242,6 @@ def axis_spanning_shape_annotation(annotation, shape_type, shape_args, kwargs):
shape_dict = annotation_params_for_rect(
shape_type, shape_args, annotation_position
)
else: # pragma: no cover (defensive)
raise ValueError("Unsupported shape_type '%s'" % shape_type)
for k in shape_dict.keys():
# only set property derived from annotation_position if it hasn't already been set
# see above: this would be better as a go.layout.Annotation then the key
Expand Down