Skip to content

Copy width/height calculating logic from kaleido #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 10 commits into from
Aug 19, 2025
Merged

Copy width/height calculating logic from kaleido #5325

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df823b4
Copy width/height calculating logic from kaleido
ayjayt Aug 13, 2025
e8049a2
Add proper defaults to dict .get()
ayjayt Aug 14, 2025
8036084
Add proper defaults to dict .get() x2
ayjayt Aug 14, 2025
bcdccf4
Format with ruff.
ayjayt Aug 14, 2025
f1e7607
Add some width/height testing.
ayjayt Aug 14, 2025
1b962ec
Fix test formatting.
ayjayt Aug 14, 2025
20035c6
Fix variable access.
ayjayt Aug 14, 2025
c589d1c
Move test_kaleido helper fns to top of file
ayjayt Aug 18, 2025
e17895e
Use pio defaults to check test defaults
ayjayt Aug 18, 2025
c249e95
Pull off ruff format.
ayjayt Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move test_kaleido helper fns to top of file
  • Loading branch information
@ayjayt
ayjayt committed Aug 18, 2025
commit c589d1c5bb0fb3ea07149016581b2c4040168c55
38 changes: 18 additions & 20 deletions tests/test_optional/test_kaleido/test_kaleido.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,24 @@

fig = {"data": [], "layout": {"title": {"text": "figure title"}}}

def create_figure(width=None, height=None):
"""Create a simple figure with optional layout dimensions."""
layout = {}
if width:
layout["width"] = width
if height:
layout["height"] = height

return go.Figure(data=[go.Scatter(x=[1, 2, 3], y=[1, 2, 3])], layout=layout)

def parse_svg_dimensions(svg_bytes):
"""Parse width and height from SVG bytes."""
svg_str = svg_bytes.decode("utf-8")
root = ET.fromstring(svg_str)
width = root.get("width")
height = root.get("height")
return int(width) if width else None, int(height) if height else None


def check_image(path_or_buffer, size=(700, 500), format="PNG"):
if format == "PDF":
Expand Down Expand Up @@ -317,26 +335,6 @@ def test_get_chrome():
mock_get_chrome.assert_called_once()


def create_figure(width=None, height=None):
"""Create a simple figure with optional layout dimensions."""
layout = {}
if width:
layout["width"] = width
if height:
layout["height"] = height

return go.Figure(data=[go.Scatter(x=[1, 2, 3], y=[1, 2, 3])], layout=layout)


def parse_svg_dimensions(svg_bytes):
"""Parse width and height from SVG bytes."""
svg_str = svg_bytes.decode("utf-8")
root = ET.fromstring(svg_str)
width = root.get("width")
height = root.get("height")
return int(width) if width else None, int(height) if height else None


def test_width_height_priority():
"""Test width/height priority: arguments > layout.width/height > defaults."""

Expand Down