Skip to content

Fix add hline not working for make_subplot if not populated #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erikp15 wants to merge 11 commits into
base: main
Choose a base branch
from
+94 −0
Open

Fix add hline not working for make_subplot if not populated #5254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3ce4b8a
fix: add_hline not working with make_subplots if not populated
Jun 27, 2025
8fd344c
Merge branch 'fix-add_hline-not-working' of https://github.com/Erikp1…
Jun 27, 2025
b92a744
Format: Update formatting to adhere to check
Jun 27, 2025
f8432ee
Format: reformat the a new unit tests
Jun 27, 2025
35b344b
Revert "Format: Update formatting to adhere to check" to fix build er…
Jun 27, 2025
64638a3
Merge branch 'main' into fix-add_hline-not-working
Erikp15 Jul 10, 2025
46e8fda
Merge branch 'main' into fix-add_hline-not-working
Erikp15 Jul 18, 2025
8d85a73
Merge branch 'main' into fix-add_hline-not-working
Erikp15 Jul 29, 2025
ad220e6
Merge branch 'main' into fix-add_hline-not-working
Erikp15 Aug 4, 2025
b4386a3
Merge branch 'main' into fix-add_hline-not-working
Erikp15 Aug 25, 2025
f258012
Merge branch 'main' into fix-add_hline-not-working
Erikp15 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format: Update formatting to adhere to check
  • Loading branch information
Erik Paskalev committed Jun 27, 2025
commit b92a744e3dd48c19aaf322366097908d351bdb1b
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Layout
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Bar
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_barpolar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Barpolar
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Box
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_candlestick.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Candlestick
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_carpet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Carpet
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_choropleth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Choropleth
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_choroplethmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Choroplethmap
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_choroplethmapbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Choroplethmapbox
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_cone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Cone
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_contour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Contour
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_contourcarpet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Contourcarpet
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_densitymap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Densitymap
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_densitymapbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Densitymapbox
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_funnel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Funnel
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_funnelarea.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Funnelarea
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_heatmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Heatmap
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_histogram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Histogram
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_histogram2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Histogram2d
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_histogram2dcontour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Histogram2dContour
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_icicle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Icicle
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Image
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_indicator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Indicator
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_isosurface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Isosurface
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_mesh3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Mesh3d
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_ohlc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Ohlc
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_parcats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Parcats
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_parcoords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Parcoords
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_pie.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Pie
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_sankey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Sankey
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scatter
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scatter3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scatter3d
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scattercarpet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scattercarpet
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scattergeo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scattergeo
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scattergl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scattergl
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scattermap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scattermap
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scattermapbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scattermapbox
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scatterpolar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scatterpolar
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scatterpolargl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scatterpolargl
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scattersmith.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scattersmith
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_scatterternary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Scatterternary
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_splom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Splom
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_streamtube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Streamtube
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_sunburst.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Sunburst
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Surface
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Table
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_treemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Treemap
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_violin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Violin
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_volume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Volume
1 change: 0 additions & 1 deletion plotly/graph_objs/layout/template/data/_waterfall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
from plotly.graph_objs import Waterfall
1 change: 0 additions & 1 deletion tests/test_core/test_shapes/test_add_hline_empty_subplots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import pytest
import plotly.graph_objects as go
from plotly.subplots import make_subplots

def test_add_hline_on_empty_subplots_creates_shape_default():
Expand Down