Skip to content

Use modern native ES6 import to load plotly.js bundle instead of requirejs which is no longer under active development #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 10 commits into from
Oct 21, 2024
Merged

Use modern native ES6 import to load plotly.js bundle instead of requirejs which is no longer under active development #4763

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d9f17a
Remove requirejs
marthacryan Sep 11, 2024
34ccc60
Remove comments describing requirejs as an option
marthacryan Sep 11, 2024
ced2c8b
Remove print statement
marthacryan Sep 11, 2024
2869130
fix failing test
marthacryan Sep 11, 2024
c5a2993
Add changelog
marthacryan Sep 12, 2024
c3fc5c8
Update to the module type and native es6 import
marthacryan Sep 12, 2024
26c4443
Update CHANGELOG.md
marthacryan Sep 18, 2024
fa4bba0
Update loading of full plotly.js library to use script module type
marthacryan Sep 23, 2024
8db8a63
Merge branch 'master' into remove-requirejs
archmoj Sep 23, 2024
d717a22
Merge branch 'master' of github.com:plotly/plotly.py into remove-requ…
marthacryan Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failing test
  • Loading branch information
@marthacryan
marthacryan committed Sep 11, 2024
commit 286913060d606fdaa133cf526c251607c055214d
6 changes: 3 additions & 3 deletions packages/python/plotly/plotly/tests/test_io/test_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,12 +306,12 @@ def test_repr_html(renderer):
+ '"></script> '
'<div id="cd462b94-79ce-42a2-887f-2650a761a144" class="plotly-graph-div" '
'style="height:100%; width:100%;"></div> <script type="text/javascript">'
" window.PLOTLYENV=window.PLOTLYENV || {};"
' if (document.getElementById("cd462b94-79ce-42a2-887f-2650a761a144"))'
" window.PLOTLYENV=window.PLOTLYENV || {};"
' if (document.getElementById("cd462b94-79ce-42a2-887f-2650a761a144"))'
' { Plotly.newPlot( "cd462b94-79ce-42a2-887f-2650a761a144",'
' [], {"template":{}},'
' {"responsive": true} ) };'
" </script> </div>"
" </script> </div>"
)
if "text/html" in bundle:
str_bundle = bundle["text/html"]
Expand Down