Skip to content

Fix stacked area hide show bug #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilykl wants to merge 2 commits into
base: master
Choose a base branch
from
+48 −3
Open

Fix stacked area hide show bug #7668

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13d013d
fix issue where some scatter traces would lose fill after series of h…
emilykl Dec 8, 2025
44bc554
add jasmine test
emilykl Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix issue where some scatter traces would lose fill after series of h… 
…ide/show operations in legend
  • Loading branch information
@emilykl
emilykl committed Dec 9, 2025
commit 13d013d8bab7c02a56b99760cef32253797df9a1
7 changes: 4 additions & 3 deletions src/traces/scatter/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ function createFills(gd, traceJoin, plotinfo) {

var trace = d[0].trace;

trace._ownFill = null;
trace._nextFill = null;

var fillData = [];
if(trace._ownfill) fillData.push('_ownFill');
if(trace._nexttrace) fillData.push('_nextFill');
Expand All @@ -91,9 +94,7 @@ function createFills(gd, traceJoin, plotinfo) {

fillJoin.enter().append('g');

fillJoin.exit()
.each(function(d) { trace[d] = null; })
.remove();
fillJoin.exit().remove();

fillJoin.order().each(function(d) {
// make a path element inside the fill group, just so
Expand Down