Skip to content

Support for custom marker symbols #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gatopeich wants to merge 11 commits into
base: master
Choose a base branch
from
+460 −6
Draft

Support for custom marker symbols #7653

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2d44177
Initial plan
Copilot Nov 19, 2025
8310635
Add addCustomMarker API for registering custom SVG markers
Copilot Nov 19, 2025
343dd6c
Add demo file for custom marker feature
Copilot Nov 19, 2025
90c697a
Add comprehensive documentation for custom marker API
Copilot Nov 19, 2025
547b0b7
Add implementation summary document
Copilot Nov 19, 2025
86086e0
Simplify API: allow passing custom functions directly as marker.symbol
Copilot Nov 21, 2025
099b0d6
Check if symbol is function before calling symbolNumber() in backoff …
Copilot Nov 22, 2025
42ab66d
Simplify function check in backoff calculation
Copilot Nov 22, 2025
d8739bd
Merge pull request #1 from gatopeich/copilot/add-custom-svg-markers
gatopeich Nov 22, 2025
398d1d4
Merge branch 'plotly:master' into master
gatopeich Nov 22, 2025
db38309
Add change draft log entry
gatopeich Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify function check in backoff calculation 
Co-authored-by: gatopeich <[email protected]>
  • Loading branch information
@gatopeich
Copilot and gatopeich committed Nov 22, 2025
commit 42ab66de5d32d14019bfc5b1894b2de58fc379d0
7 changes: 1 addition & 6 deletions src/components/drawing/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,12 +1506,7 @@ function applyBackoff(pt, start) {
var endMarkerSize = endMarker.size;
if (Lib.isArrayOrTypedArray(endMarkerSize)) endMarkerSize = endMarkerSize[endI];

// Custom functions don't have backoff values, only built-in symbols do
var backoffValue = 0;
if (endMarker && typeof endMarkerSymbol !== 'function') {
backoffValue = drawing.symbolBackOffs[drawing.symbolNumber(endMarkerSymbol)] || 0;
}
b = backoffValue * endMarkerSize;
b = endMarker && typeof endMarkerSymbol !== 'function' ? (drawing.symbolBackOffs[drawing.symbolNumber(endMarkerSymbol)] || 0) * endMarkerSize : 0;
b += drawing.getMarkerStandoff(d[endI], trace) || 0;
}

Expand Down