Skip to content

Fix behavior of customdata when using typed arrays #7608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 4 commits into from
Oct 27, 2025
+129 −50
Merged

Fix behavior of customdata when using typed arrays #7608

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9fc12f
run formatter
emilykl Oct 27, 2025
29f6789
use Lib.isArrayOrTypedArray instead of Array.isArray
emilykl Oct 27, 2025
fc257ec
add draftlog
emilykl Oct 27, 2025
008678f
add tests for typed array in customdata
emilykl Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Lib.isArrayOrTypedArray instead of Array.isArray
  • Loading branch information
@emilykl
emilykl committed Oct 27, 2025
commit 29f678916635731dfd5da4ccae02c2fc3a9b598c
2 changes: 1 addition & 1 deletion src/components/fx/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ function getPointKey(astr) {

function getPointData(val, pointNumber) {
if (Array.isArray(pointNumber)) {
if (Array.isArray(val) && Array.isArray(val[pointNumber[0]])) {
if (Lib.isArrayOrTypedArray(val) && Lib.isArrayOrTypedArray(val[pointNumber[0]])) {
return val[pointNumber[0]][pointNumber[1]];
}
} else {
Expand Down