Skip to content

build: Add build step before generating the schema #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 8 commits into from
Oct 20, 2025
+278 −423
Merged

build: Add build step before generating the schema #7589

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd910a1
Linting/formatting
camdecoster Oct 15, 2025
dbe27df
Move esbuild configs to one file, update references
camdecoster Oct 15, 2025
8c44130
Add build step to schema npm script
camdecoster Oct 15, 2025
c8818ec
Linting/formatting
camdecoster Oct 16, 2025
0ff3ebb
Move build step into schema script
camdecoster Oct 16, 2025
9b651a9
Add descriptions to esbuild configs
camdecoster Oct 20, 2025
b61a0b8
Fix repo URL
camdecoster Oct 20, 2025
570640c
Move reused code into new file
camdecoster Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Linting/formatting
  • Loading branch information
@camdecoster
camdecoster committed Oct 16, 2025
commit c8818ec1b162d7323ab391aa27f28042403be89b
22 changes: 7 additions & 15 deletions tasks/schema.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,20 @@ function isArray(v) {
}

function isObject(v) {
return typeof v === 'object' && v !== null && !(isArray(v));
return typeof v === 'object' && v !== null && !isArray(v);
}

function isArrayOfObjects(v) {
return isArray(v) && isObject(v[0]);
}

function typeHandle(v) {
return (
isArrayOfObjects(v) ? sortArrayOfObjects(v) :
isObject(v) ? sortObject(v) :
v
);
return isArrayOfObjects(v) ? sortArrayOfObjects(v) : isObject(v) ? sortObject(v) : v;
}

function sortArrayOfObjects(list) {
var newList = [];
for(var i = 0; i < list.length; i++) {
for (var i = 0; i < list.length; i++) {
newList[i] = typeHandle(list[i]);
}

Expand All @@ -42,7 +38,7 @@ function sortObject(obj) {
allKeys.sort(caseInsensitive);

var newObj = {};
for(var i = 0; i < allKeys.length; i++) {
for (var i = 0; i < allKeys.length; i++) {
var key = allKeys[i];
newObj[key] = typeHandle(obj[key]);
}
Expand All @@ -64,7 +60,7 @@ function makeSchema(plotlyPath, schemaPath) {
var lenAfterSort = plotSchemaStr.length;
var linesBeforeSort = plotSchemaRaw.split('\n').length;
var linesAfterSort = plotSchemaStr.split('\n').length;
if(linesAfterSort !== linesBeforeSort || lenAfterSort !== lenBeforeSort) {
if (linesAfterSort !== linesBeforeSort || lenAfterSort !== lenBeforeSort) {
throw 'plot schema should have the same length & number of lines before and after sort';
} else {
console.log('ok ' + path.basename(schemaPath));
Expand All @@ -73,13 +69,9 @@ function makeSchema(plotlyPath, schemaPath) {

var isDist = process.argv.indexOf('dist') !== -1;

var pathToSchema = isDist ?
constants.pathToSchemaDist :
constants.pathToSchemaDiff;
var pathToSchema = isDist ? constants.pathToSchemaDist : constants.pathToSchemaDiff;

var pathToPlotly = isDist ?
constants.pathToPlotlyDistWithMeta :
constants.pathToPlotlyBuild;
var pathToPlotly = isDist ? constants.pathToPlotlyDistWithMeta : constants.pathToPlotlyBuild;

// output plot-schema JSON
makeSchema(pathToPlotly, pathToSchema);