Skip to content

Pie legend and showlegend per slice #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 24 commits into from
Dec 3, 2025
Merged

Pie legend and showlegend per slice #7580

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4fc0e3b
Make pie.showlegend accept a boolean array to configure individual sl…
my-tien Oct 1, 2025
417ca2e
Make pie.legend accept a boolean array to configure individual slice …
my-tien Oct 10, 2025
449598d
Mocks for testing pie.legend and pie.showlegend arrays.
my-tien Oct 13, 2025
178959e
Add draftlog for #7580
my-tien Oct 13, 2025
3f9143d
Add missing plot-schema change
my-tien Oct 13, 2025
f9c65da
Baselines for tests zz-pie-slice-legend and zz-pie-slice-legend2
my-tien Oct 13, 2025
09bcc61
Fix defaults for legend when pie has no slices.
my-tien Oct 13, 2025
dd73d5a
Change pie influence on default legend visibility only for non-empty …
my-tien Oct 13, 2025
71c01fb
debugger statement…
my-tien Oct 13, 2025
177dca3
Merge remote-tracking branch 'origin-plotly/master' into pie-legend-v…
my-tien Nov 25, 2025
3e5e53f
Clarify that pie legend and showlegend can only be arrays if `values`…
my-tien Nov 26, 2025
ab11db2
Add baseline test for pie legend/showlegend arrays when label0 is use…
my-tien Nov 26, 2025
73c531e
baseline image for zz-pie-slice-legend3.png
my-tien Nov 26, 2025
8f983db
Fix indentation in zz-pie-slice-legend mocks
my-tien Nov 27, 2025
a115e4e
Enhance readability in legend groupdefaults
my-tien Nov 27, 2025
ef93f2c
Fix default legend's groupdefaults calculation being skipped when pie…
my-tien Nov 27, 2025
7ec5316
coerce.js boolean and subplotid: Actually do checks on array values.
my-tien Nov 27, 2025
795b911
Fix missing opts param in boolean coerceFunction
my-tien Nov 27, 2025
a73c4f9
Revert accidental change in zz-pie-slice-legend3 mock
my-tien Nov 27, 2025
2636c7b
Replace baseline images for zz-pie-slice[2].png
my-tien Nov 27, 2025
b968041
Update src/lib/coerce.js
my-tien Dec 2, 2025
51fc434
Simplify code for calculation of pie showlegend defaults
my-tien Dec 2, 2025
7aa08d8
Simplify coerce functions for boolean and subplotId
my-tien Dec 2, 2025
cbe853b
Update draftlog
camdecoster Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change pie influence on default legend visibility only for non-empty … 
…pies with showlegend and/or legend as arrays
  • Loading branch information
@my-tien
my-tien committed Oct 13, 2025
commit dd73d5aeaaf3e7d8d1e86f6c5baebd2385d66d4b
61 changes: 30 additions & 31 deletions src/components/legend/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,47 +45,44 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {

var shapesWithLegend = (layoutOut.shapes || []).filter(function(d) { return d.showlegend; });

function isPieWithLegendArray(trace) {
return Registry.traceIs(trace, 'pie-like')
&& trace._length != null
&& (Array.isArray(trace.legend) || Array.isArray(trace.showlegend));
};
fullData
.filter(function(trace) { return Registry.traceIs(trace, 'pie-like'); })
.filter(isPieWithLegendArray)
.map(function (trace, idx) {
if (trace.visible) {
legendTraceCount++;
}
if(Array.isArray(trace.legend)) {
for(var index = 0; index < trace._length; index++) {
var legend = trace.legend[index] || 'legend';
if(legend === legendId) {
// showlegend can be undefined, boolean or a boolean array.
// will fall back to default if undefined or if array index is out-of-range
if(
!Array.isArray(trace.showlegend)
? trace.showlegend || trace._dfltShowLegend
: trace.showlegend[index] == null
? trace._dfltShowLegend
: trace.showlegend[index]
) {
legendReallyHasATrace = true;
legendTraceCount++;
}
for(var index = 0; index < trace._length; index++) {
var legend = (Array.isArray(trace.legend) ? trace.legend[index] : trace.legend) || 'legend';
if(legend === legendId) {
// showlegend can be undefined, boolean or a boolean array.
// will fall back to default if undefined or if array index is out-of-range
if(
!Array.isArray(trace.showlegend)
? trace.showlegend || trace._dfltShowLegend
: trace.showlegend[index] == null
? trace._dfltShowLegend
: trace.showlegend[index]
) {
legendReallyHasATrace = true;
legendTraceCount++;
}
}
if(
legendId === 'legend' &&
(trace._length == null || trace._length > trace.legend.length)
) {
for(var idx = trace.legend.length; idx < trace._length; idx++) {
}
if(legendId === 'legend' && trace._length > trace.legend.length) {
for(var idx = trace.legend.length; idx < trace._length; idx++) {
legendReallyHasATrace = true;
legendTraceCount++;
}
}
} else if(legendId === (trace.legend || 'legend')) {
legendReallyHasATrace = true;
legendTraceCount += trace._length || 1;
}
});

var allLegendItems = fullData.concat(shapesWithLegend).filter(function(d) {
return !Registry.traceIs(trace, 'pie-like') && legendId === (d.legend || 'legend');
return !isPieWithLegendArray(trace) && legendId === (d.legend || 'legend');
});

for(var i = 0; i < allLegendItems.length; i++) {
Expand All @@ -110,9 +107,11 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
legendTraceCount++;
if(trace.showlegend) {
legendReallyHasATrace = true;
// Always show the legend by default if there's only one trace
// but it's explicitly shown
if(trace._input.showlegend === true) {
// Always show the legend by default if there's a pie,
// or if there's only one trace but it's explicitly shown
if(!isShape && Registry.traceIs(trace, 'pie-like') ||
trace._input.showlegend === true
) {
legendTraceCount++;
}
}
Expand All @@ -130,7 +129,7 @@ function groupDefaults(legendId, layoutIn, layoutOut, fullData) {
'reversed+grouped' : 'grouped';
}
}

debugger
var showLegend = Lib.coerce(
layoutIn,
layoutOut,
Expand Down