Skip to content

fix: Update config diff check method to handle nested arrays #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 13 commits into from
Oct 15, 2025
+2,937 −2,477
Merged

fix: Update config diff check method to handle nested arrays #7579

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b480d04
Linting/formatting
camdecoster Oct 10, 2025
34a669e
Move diff function to helpers and update to handle nested arrays
camdecoster Oct 10, 2025
364466a
Add tests for diff function
camdecoster Oct 10, 2025
3b3816f
Switch object clone method to keep undefined values in clone
camdecoster Oct 10, 2025
20c534f
Switch loops to improve performance
camdecoster Oct 13, 2025
47be541
Fix test label
camdecoster Oct 13, 2025
ef102cc
Add draftlog
camdecoster Oct 13, 2025
1b65938
Fix bad loop conversion
camdecoster Oct 14, 2025
0da832e
Move constant to top of file; remove unused require
camdecoster Oct 14, 2025
2767f07
Switch method to check for equality
camdecoster Oct 15, 2025
01e698a
Update tests per method change
camdecoster Oct 15, 2025
8ceebdf
Handle when collections aren't objects or object+array
camdecoster Oct 15, 2025
3bc5b7e
Add more tests
camdecoster Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch loops to improve performance
  • Loading branch information
@camdecoster
camdecoster committed Oct 13, 2025
commit 20c534fe7c4c039dab35c824dca3492450501973
11 changes: 7 additions & 4 deletions src/plot_api/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,19 +520,22 @@ const hasCollectionChanged = (oldCollection, newCollection) => {
if ([oldCollection, newCollection].every((a) => Array.isArray(a))) {
if (oldCollection.length !== newCollection.length) return true;

return oldCollection.some((oldVal, i) => {
for (let i = 0; i < oldCollection.length; i++) {
const oldVal = oldCollection[i];
const newVal = newCollection[i];
if (oldVal !== newVal) return isArrayOrObject(oldVal, newVal) ? hasCollectionChanged(oldVal, newVal) : true;
});
}
} else {
if (Object.keys(oldCollection).length !== Object.keys(newCollection).length) return true;

return Object.keys(oldCollection).some((k) => {
for (const k in oldCollection) {
if (k.startsWith('_')) return false;
Copy link
Contributor

@emilykl emilykl Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems wrong, am I missing something? Is it supposed to be if (k.startsWith('_')) continue; ?

Copy link
Contributor

@emilykl emilykl Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, looking closely this whole loop is problematic; it should only ever return true from within the loop. Line 535 will return false sometimes and short-circuit the whole loop if hasCollectionChanged(oldVal, newVal) returns false.

Copy link
Contributor Author

@camdecoster camdecoster Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I did a poor job of converting this loop from it's previous iteration. I updated it to only return when true.

const oldVal = oldCollection[k];
const newVal = newCollection[k];
if (oldVal !== newVal) return isArrayOrObject(oldVal, newVal) ? hasCollectionChanged(oldVal, newVal) : true;
});
}
}

return false;
};
exports.hasCollectionChanged = hasCollectionChanged;