Skip to content

Set cliponaxis: false by default for bar traces with text and textposition: 'auto' or 'outside' #7558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilykl wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Set cliponaxis: false by default for bar traces with text and textposition: 'auto' or 'outside' #7558

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ebb1af
set by default for bar traces with
emilykl Sep 15, 2025
84d5c7d
add jasmine tests
emilykl Sep 15, 2025
e10bfcd
update image baseline
emilykl Sep 16, 2025
180fecf
update cliponaxis description
emilykl Sep 16, 2025
9519d75
also set cliponaxis to false when textposition is auto
emilykl Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add jasmine tests
  • Loading branch information
@emilykl
emilykl committed Sep 15, 2025
commit 84d5c7d8bf80abb8ef56a41626605e5b4fdc3877
40 changes: 40 additions & 0 deletions test/jasmine/tests/bar_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,46 @@ describe('Bar.supplyDefaults', function() {
expect(traceOut.insidetextfont.size).toBe(20);
});

it('should set cliponaxis to false when text has value and textposition is outside', function() {
traceIn = {
y: [1, 2, 3],
text: ['A', 'B', 'C'],
textposition: 'outside'
};
supplyDefaults(traceIn, traceOut, defaultColor, {});
expect(traceOut.cliponaxis).toBe(false);
});

it('should set cliponaxis to default (true) when text is not provided', function() {
traceIn = {
y: [1, 2, 3],
textposition: 'outside'
};
supplyDefaults(traceIn, traceOut, defaultColor, {});
expect(traceOut.cliponaxis).toBe(true);
});

it('should set cliponaxis to default (true) when textposition is not outside', function() {
traceIn = {
y: [1, 2, 3],
text: ['A', 'B', 'C'],
textposition: 'inside'
};
supplyDefaults(traceIn, traceOut, defaultColor, {});
expect(traceOut.cliponaxis).toBe(true);
});

it('should respect explicit cliponaxis setting even with text and outside position', function() {
traceIn = {
y: [1, 2, 3],
text: ['A', 'B', 'C'],
textposition: 'outside',
cliponaxis: true
};
supplyDefaults(traceIn, traceOut, defaultColor, {});
expect(traceOut.cliponaxis).toBe(true);
});

it('should inherit layout.calendar', function() {
traceIn = {
x: [1, 2, 3],
Expand Down
Loading