Skip to content

feat: Switch color processing library #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
camdecoster wants to merge 19 commits into
base: master
Choose a base branch
from
+907 −607
Draft

feat: Switch color processing library #7536

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c17371a
Switch color library
camdecoster Aug 15, 2025
d6d1e9e
Add utility functions
camdecoster Aug 19, 2025
b15bdca
Switch references to new color library
camdecoster Aug 21, 2025
a1e2dee
Fix bad method calls; fix NaN bugs
camdecoster Aug 21, 2025
4b97ca9
Update tests per library change
camdecoster Aug 21, 2025
17fe004
Use correct method name
camdecoster Aug 22, 2025
e314022
Use alternate coerce function to avoid gridcolor of `false`
camdecoster Aug 22, 2025
0ab7cd1
Merge remote-tracking branch 'origin/master' into cam/7523/switch-col…
camdecoster Aug 26, 2025
7552832
Update function call
camdecoster Aug 26, 2025
5d0322a
Update tests per library change
camdecoster Aug 26, 2025
5964bee
Update attribute, description to remove hsv
camdecoster Aug 29, 2025
d6853e4
Convert hsv value to rgb in test mock
camdecoster Aug 29, 2025
93a8365
Override color-string package dependency
camdecoster Nov 17, 2025
fe7b607
Merge remote-tracking branch 'origin/master' into cam/7523/switch-col…
camdecoster Nov 17, 2025
5c2dbda
Remove tinycolor2 library
camdecoster Nov 17, 2025
2d5d3e0
Linting/formatting
camdecoster Nov 17, 2025
5e329a6
Update test
camdecoster Nov 17, 2025
8a3f5f4
Use minified plotly.js for making baselines
camdecoster Nov 18, 2025
b43ff75
Add logging
camdecoster Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use correct method name
  • Loading branch information
@camdecoster
camdecoster committed Aug 22, 2025
commit 17fe004f3cf3235fec9cc4909457859e841c4563
4 changes: 2 additions & 2 deletions src/lib/coerce.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ exports.valObjectMeta = {
otherOpts: ['dflt'],
coerceFunction: function(v, propOut, dflt) {
if(!Array.isArray(v) || !v.length) propOut.set(dflt);
else if(v.every(color => Color.isvalid(color))) propOut.set(v);
else if(v.every(color => Color.isValid(color))) propOut.set(v);
else propOut.set(dflt);
}
},
Expand Down Expand Up @@ -450,7 +450,7 @@ exports.coerce = function(containerIn, containerOut, attributes, attribute, dflt
* Variation on coerce
*
* Uses coerce to get attribute value if user input is valid,
* returns attribute default if user input it not valid or
* returns attribute default if user input is not valid or
* returns false if there is no user input.
*/
exports.coerce2 = function(containerIn, containerOut, attributes, attribute, dflt) {
Expand Down