Skip to content

fix: title text cannot be edited for multiple plots/components (regression since v3.0.0) #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 4 commits into from
Oct 7, 2025
+8 −7
Merged

fix: title text cannot be edited for multiple plots/components (regression since v3.0.0) #7513

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
595deef
fix: title text cannot be edited (regression since v3.0.0)
Lexachoc Aug 7, 2025
b14a635
Create 7513_fix.md
Lexachoc Aug 7, 2025
85df076
Update polar.js
Lexachoc Aug 7, 2025
59be210
Update delay time in transition_test.js
Lexachoc Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: title text cannot be edited (regression since v3.0.0)
  • Loading branch information
@Lexachoc
Lexachoc authored Aug 7, 2025
commit 595deefee356dbcdc25b1b0f61152041c4165078
2 changes: 1 addition & 1 deletion src/components/colorbar/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ function drawColorBar(g, opts, gd) {
function drawTitle(titleClass, titleOpts) {
var dfltTitleOpts = {
propContainer: ax,
propName: opts._propPrefix + 'title',
propName: opts._propPrefix + 'title.text',
traceIndex: opts._traceIndex,
_meta: opts._meta,
placeholder: fullLayout._dfltTitle.colorbar,
Expand Down
2 changes: 1 addition & 1 deletion src/components/rangeslider/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ module.exports = function(gd) {
if(axisOpts.side === 'bottom') {
Titles.draw(gd, axisOpts._id + 'title', {
propContainer: axisOpts,
propName: axisOpts._name + '.title',
propName: axisOpts._name + '.title.text',
placeholder: fullLayout._dfltTitle.x,
attributes: {
x: axisOpts._offset + axisOpts._length / 2,
Expand Down
2 changes: 1 addition & 1 deletion src/plots/polar/polar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ proto.updateRadialAxisTitle = function(fullLayout, polarLayout, _angle) {
var cx = _this.cx;
var cy = _this.cy;
var radialLayout = _this.getRadial(polarLayout);
var titleClass = _this.id + 'title';
var titleClass = _this.id + 'title.text';

var pad = 0;

Expand Down
6 changes: 3 additions & 3 deletions src/plots/ternary/ternary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ proto.drawAxes = function(doTitles) {

layers['a-title'] = Titles.draw(gd, 'a' + titlesuffix, {
propContainer: aaxis,
propName: _this.id + '.aaxis.title',
propName: _this.id + '.aaxis.title.text',
placeholder: _(gd, 'Click to enter Component A title'),
attributes: {
x: _this.x0 + _this.w / 2,
Expand All @@ -385,7 +385,7 @@ proto.drawAxes = function(doTitles) {
});
layers['b-title'] = Titles.draw(gd, 'b' + titlesuffix, {
propContainer: baxis,
propName: _this.id + '.baxis.title',
propName: _this.id + '.baxis.title.text',
placeholder: _(gd, 'Click to enter Component B title'),
attributes: {
x: _this.x0 - bpad,
Expand All @@ -395,7 +395,7 @@ proto.drawAxes = function(doTitles) {
});
layers['c-title'] = Titles.draw(gd, 'c' + titlesuffix, {
propContainer: caxis,
propName: _this.id + '.caxis.title',
propName: _this.id + '.caxis.title.text',
placeholder: _(gd, 'Click to enter Component C title'),
attributes: {
x: _this.x0 + _this.w + bpad,
Expand Down