Skip to content

Fix: Optimize Drawing.bBox calls to prevent unnecessary reflows in complex DOMs #7497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imbansalaniket wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Optimize Drawing.bBox calls to prevent unnecessary reflows in complex DOMs #7497

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5045adf
Eliminate unnecessary DOM reflows
Jul 28, 2025
204dd5a
Add draftlogs/7497_fix.md
imbansalaniket Jul 28, 2025
d3cc2d0
Merge branch 'plotly:master' into fix/performance-issue-unnecessary-r…
imbansalaniket Jul 30, 2025
58c9e45
Handled not in DOM node Drawing.bBox
Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Handled not in DOM node Drawing.bBox
  • Loading branch information
Aniket Bansal committed Aug 4, 2025
commit 58c9e456bebe2e8dbc5cef4ffd336853a5667591
59 changes: 34 additions & 25 deletions src/components/drawing/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1514,16 +1514,39 @@ drawing.bBox = function(node, inTester, hash) {
var bb = {};
if (node.tagName !== "text") {
var nodeBB = node.getBBox();
bb = {
height: nodeBB.height,
width: nodeBB.width,
left: nodeBB.x,
top: nodeBB.y,
right: nodeBB.x + nodeBB.width,
bottom: nodeBB.y + nodeBB.height
};
if (Object.keys(nodeBB).length) {
bb = {
height: nodeBB.height,
width: nodeBB.width,
left: nodeBB.x,
top: nodeBB.y,
right: nodeBB.x + nodeBB.width,
bottom: nodeBB.y + nodeBB.height
};
} else {
bb = testNodeInTester(node, inTester);
}
} else {
var testNode, tester;
bb = testNodeInTester(node, inTester);
}

// make sure we don't have too many saved boxes,
// or a long session could overload on memory
// by saving boxes for long-gone elements
if(savedBBoxesCount >= maxSavedBBoxes) {
drawing.savedBBoxes = {};
savedBBoxesCount = 0;
}

// cache this bbox
if(hash) drawing.savedBBoxes[hash] = bb;
savedBBoxesCount++;

return Lib.extendFlat({}, bb);
};

function testNodeInTester(node, inTester) {
var testNode, tester;
if(inTester) {
testNode = node;
} else {
Expand Down Expand Up @@ -1554,22 +1577,8 @@ drawing.bBox = function(node, inTester, hash) {
right: testRect.right - refRect.left,
bottom: testRect.bottom - refRect.top
};
}

// make sure we don't have too many saved boxes,
// or a long session could overload on memory
// by saving boxes for long-gone elements
if(savedBBoxesCount >= maxSavedBBoxes) {
drawing.savedBBoxes = {};
savedBBoxesCount = 0;
}

// cache this bbox
if(hash) drawing.savedBBoxes[hash] = bb;
savedBBoxesCount++;

return Lib.extendFlat({}, bb);
};
return bb;
}

// capture everything about a node (at least in our usage) that
// impacts its bounding box, given that bBox clears x, y, and transform
Expand Down