Skip to content

fix: React to config changes #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camdecoster merged 8 commits into from
Sep 4, 2025
Merged

fix: React to config changes #7475

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
63798bf
react to config changes
archmoj Jul 15, 2025
d9e7b2d
adjust test
archmoj Jul 16, 2025
1ff3b25
draftlog
archmoj Jul 17, 2025
29ccfaf
Save event listeners when calling newPlot
camdecoster Sep 3, 2025
5e2aff5
Merge remote-tracking branch 'origin/master' into react-to-config-cha…
camdecoster Sep 4, 2025
5965bdf
Don't update after plot count in tests
camdecoster Sep 4, 2025
d7be55a
Update draftlog file name
camdecoster Sep 4, 2025
6133268
Update draftlog description
camdecoster Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't update after plot count in tests
  • Loading branch information
@camdecoster
camdecoster committed Sep 4, 2025
commit 5965bdf3606d1934ae719b1b6002bcf7aa0de7d7
6 changes: 0 additions & 6 deletions test/jasmine/tests/plot_api_react_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@ describe('@noCIdep Plotly.react', function() {
expect(d3SelectAll('.drag').size()).toBe(11);
expect(d3SelectAll('.gtitle').text()).toBe('Click to enter Plot title');
expect(d3SelectAll('.gtitle-subtitle').text()).toBe('Click to enter Plot subtitle');

afterPlotCnt++; // since it uses newPlot pathway as a result of config change
countCalls({plot: 1});

return Plotly.react(gd, data, layout, {staticPlot: true});
Expand All @@ -428,8 +426,6 @@ describe('@noCIdep Plotly.react', function() {
expect(d3SelectAll('.drag').size()).toBe(0);
expect(d3SelectAll('.gtitle').size()).toBe(0);
expect(d3SelectAll('.gtitle-subtitle').size()).toBe(0);

afterPlotCnt++; // since it uses newPlot pathway as a result of config change
countCalls({plot: 1});

return Plotly.react(gd, data, layout, {});
Expand All @@ -438,8 +434,6 @@ describe('@noCIdep Plotly.react', function() {
expect(d3SelectAll('.drag').size()).toBe(11);
expect(d3SelectAll('.gtitle').size()).toBe(0);
expect(d3SelectAll('.gtitle-subtitle').size()).toBe(0);

afterPlotCnt++; // since it uses newPlot pathway as a result of config change
countCalls({plot: 1});
})
.then(done, done.fail);
Expand Down