Skip to content

feat: Add min/max scale limits for geo plots #7371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camdecoster wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: Add min/max scale limits for geo plots #7371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
57307ee
feat(geo): support min/max scale limits
mojoaxel Oct 5, 2020
d870252
refactor: rename min/max scale limits
mojoaxel Oct 26, 2020
2d9e5f2
chore: use dflt: -1 instad of null
mojoaxel Oct 26, 2020
dd635ee
feat: handle maxscale default in scaleExtent
mojoaxel Oct 26, 2020
8a2c0c5
chore: only rerender on zoom if scale changes
mojoaxel Oct 26, 2020
f882191
chore: fix typo in min/maxscale attributes
mojoaxel Oct 26, 2020
8ed949f
test: adopt test/plot-schema.json to new plot-schema
mojoaxel Jun 10, 2024
29b4316
Trigger initial zoom event to set minscale
camdecoster Feb 18, 2025
048f178
Switch to ES5 syntax
camdecoster Feb 21, 2025
c6007a8
Merge remote-tracking branch 'origin/master' into cam/5192/add-min-ma…
camdecoster Feb 21, 2025
84cd037
Switch to getBBox and fix zoom.event call
camdecoster Feb 22, 2025
d9fca8b
Add draft log
camdecoster Feb 22, 2025
5f0083f
Merge remote-tracking branch 'origin/master' into cam/5192/add-min-ma…
archmoj Jul 21, 2025
0a1f133
Merge remote-tracking branch 'origin/master' into cam/5192/add-min-ma…
camdecoster Jul 23, 2025
ee8597f
Add event check before triggering zoom transition
camdecoster Jul 24, 2025
9b04737
Don't delete default scales for fitbounds
camdecoster Jul 24, 2025
32feb89
add tests for various cases
archmoj Jul 21, 2025
65665fe
Update tests to check scale against scaleExtent
camdecoster Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: use dflt: -1 instad of null
  • Loading branch information
@mojoaxel @camdecoster
mojoaxel authored and camdecoster committed Feb 18, 2025
commit 2d9e5f2726383a3cb6aa5dce4635733fd2d6f881
1 change: 1 addition & 0 deletions src/components/modebar/buttons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ function handleGeo(gd, ev) {
var minscale = geoLayout.projection.minscale;
var maxscale = geoLayout.projection.maxscale;

if(maxscale < 0) maxscale = Infinity;
var newScale = (val === 'in') ? 2 * scale : 0.5 * scale;

// make sure the scale is within the min/max bounds
Expand Down
2 changes: 1 addition & 1 deletion src/plots/geo/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ var attrs = module.exports = overrideAll({
maxscale: {
valType: 'number',
min: 0,
dflt: null,
dflt: -1,
Copy link
Contributor

@archmoj archmoj Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try setting dflt: 0 in the API and handle the case of zero instead of -1.

Copy link
Contributor Author

@camdecoster camdecoster Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We represent Infinity with -1 since Infinity isn't valid in JSON. If we made this change, how would we handle when a user wants to use Infinity instead of 0 (which is also a valid value).

description: [
'Maximal zoom level of the map view.',
'A maxScale of *2* (200%) corresponds to a zoom level',
Expand Down