Skip to content

Replace country-regex with i18n-iso-countries #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimitrov570 wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Replace country-regex with i18n-iso-countries #7366

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e803c5e
replace country-regex with i18n-iso-countries
dimitrov570 Feb 13, 2025
a31d360
add draftlog readme
dimitrov570 Feb 13, 2025
3067e6d
Merge branch 'master' into replace-country-regex
camdecoster Aug 1, 2025
238ac94
Update per PR feedback
camdecoster Aug 1, 2025
767412c
Fix incorrect merge conflict resolution
camdecoster Aug 1, 2025
c569313
Update Browserify adapter transform function to pass JSON through
camdecoster Aug 4, 2025
86002d2
Update country names in test mock
camdecoster Aug 5, 2025
d33e9c9
Update additional test mock
camdecoster Aug 6, 2025
49fac99
Update mock data per previous changes
camdecoster Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update per PR feedback
  • Loading branch information
@camdecoster
camdecoster committed Aug 1, 2025
commit 238ac94b503376642da5a7c915034cef78a0cfcb
2 changes: 1 addition & 1 deletion draftlogs/7366_change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
- Replace country-regex with i18n-iso-countries [[#7366](https://github.com/plotly/plotly.js/pull/7366)]
- Replace country-regex package with i18n-iso-countries [[#7366](https://github.com/plotly/plotly.js/pull/7366)]
2 changes: 1 addition & 1 deletion src/lib/geo_location_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ var d3 = require('@plotly/d3');
var { area: turfArea } = require('@turf/area');
var { centroid: turfCentroid } = require('@turf/centroid');
var { bbox: turfBbox } = require('@turf/bbox');
const countries = require("i18n-iso-countries");

var identity = require('./identity');
var loggers = require('./loggers');
var isPlainObject = require('./is_plain_object');
var nestedProperty = require('./nested_property');
var polygon = require('./polygon');

const countries = require("i18n-iso-countries");
countries.registerLocale(require("i18n-iso-countries/langs/en.json"));

var locationmodeToIdFinder = {
Expand Down