Skip to content

Add "SI extended" formatting rule for the tick exponents #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexshoe merged 10 commits into from
Oct 16, 2025
+202 −115
Merged

Add "SI extended" formatting rule for the tick exponents #7249

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8d6861f
Add "SI extended" to display numbers in the full SI unit range (10^-3…
dberardi99 Oct 24, 2024
c0ec891
Modify 20.json mock and relative baseline to show the new "SI extende…
dberardi99 Oct 24, 2024
d78cfc1
Fix bottom limit of exponent and add comments for the new "SI extende…
dberardi99 Oct 24, 2024
8f361a2
Merge remote-tracking branch 'origin/master' into pr/7249
alexshoe Oct 15, 2025
15fa0ba
Fix formatting using biome
alexshoe Oct 15, 2025
13921b3
update plot-schema diff
alexshoe Oct 15, 2025
6806e55
Fix baseline mock image
alexshoe Oct 15, 2025
c591bb8
Simplify logic in `numFormat`
alexshoe Oct 16, 2025
be865a6
Merge remote-tracking branch 'origin/master' into pr/7249
alexshoe Oct 16, 2025
beab33e
Add entry to draftlogs
alexshoe Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify logic in numFormat
  • Loading branch information
@alexshoe
alexshoe committed Oct 16, 2025
commit c591bb86e604770e89f7fdf0d844ece77e8be826
33 changes: 22 additions & 11 deletions src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,11 +2066,9 @@ function num2frac(num) {
var SIPREFIXES = ['f', 'p', 'n', 'μ', 'm', '', 'k', 'M', 'G', 'T'];

// extending SI prefixes
var SIPREFIXES_EXTENDED = ['q', 'r', 'y', 'z', 'a', 'f', 'p', 'n', 'μ', 'm', '', 'k', 'M', 'G', 'T', 'P', 'E', 'Z', 'Y', 'R', 'Q'];
var SIPREFIXES_EXTENDED = ['q', 'r', 'y', 'z', 'a', ...SIPREFIXES, 'P', 'E', 'Z', 'Y', 'R', 'Q'];

function isSIFormat(exponentFormat) {
return exponentFormat === 'SI' || exponentFormat === 'SI extended' || exponentFormat === 'B';
}
const isSIFormat = (exponentFormat) => ['SI', 'SI extended','B'].includes(exponentFormat);

// are we beyond the range of common SI prefixes?
// 10^-16 -> 1x10^-16
Expand All @@ -2083,10 +2081,26 @@ function beyondSI(exponent) {
return exponent > 14 || exponent < -15;
}


// are we beyond the range of all SI prefixes?
// 10^-31 -> 1x10^-31
// 10^-30 -> 1q
// 10^-29 -> 10q
// ...
// 10^31 -> 10Q
// 10^32 -> 100Q
// 10^33 -> 1x10^33
function beyondSIExtended(exponent) {
return exponent > 32 || exponent < -30;
}

function shouldSwitchSIToPowerFormat(exponent, exponentFormat) {
if (!isSIFormat(exponentFormat)) return false;
if (exponentFormat === 'SI extended' && beyondSIExtended(exponent)) return true;
if (exponentFormat !== 'SI extended' && beyondSI(exponent)) return true;
return false;
}

function numFormat(v, ax, fmtoverride, hover) {
var isNeg = v < 0;
// max number of digits past decimal point to show
Expand Down Expand Up @@ -2162,8 +2176,7 @@ function numFormat(v, ax, fmtoverride, hover) {

// add exponent
if(exponent && exponentFormat !== 'hide') {
if((isSIFormat(exponentFormat) && exponentFormat !== 'SI extended' && beyondSI(exponent)) ||
(isSIFormat(exponentFormat) && exponentFormat === 'SI extended' && beyondSIExtended(exponent))) exponentFormat = 'power';
if (shouldSwitchSIToPowerFormat(exponent, exponentFormat)) exponentFormat = 'power';

var signedExponent;
if(exponent < 0) signedExponent = MINUS_SIGN + -exponent;
Expand All @@ -2177,11 +2190,9 @@ function numFormat(v, ax, fmtoverride, hover) {
} else if(exponentFormat === 'B' && exponent === 9) {
v += 'B';
} else if(isSIFormat(exponentFormat)) {
if(exponentFormat !== 'SI extended') {
v += SIPREFIXES[exponent / 3 + 5];
} else if(exponentFormat === 'SI extended') {
v += SIPREFIXES_EXTENDED[exponent / 3 + 10];
}
v += exponentFormat === 'SI extended'
? SIPREFIXES_EXTENDED[exponent / 3 + 10]
: SIPREFIXES[exponent / 3 + 5];
}
}

Expand Down