Skip to content

introduce group scatter attributes #6381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 6 commits into from
Dec 21, 2022
Merged

introduce group scatter attributes #6381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1f876a
introduce group scattermode attributes
archmoj Nov 22, 2022
fca1c11
drop scattergroupgap
archmoj Dec 12, 2022
f10b777
Merge remote-tracking branch 'origin/master' into group-scattermode
archmoj Dec 20, 2022
cc99d18
add group positioning options to scatter
archmoj Dec 20, 2022
918068d
add mock using alignmentgroup and offsetgroup
archmoj Dec 20, 2022
e98f3c6
draft log for PR 6381
archmoj Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drop scattergroupgap
  • Loading branch information
@archmoj
archmoj committed Dec 12, 2022
commit fca1c114936cf5f1240a7630f4b17e6d4b5e2410
3 changes: 1 addition & 2 deletions src/traces/scatter/cross_trace_calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ function groupCrossTraceCalc(gd, plotinfo) {

var opts = {
mode: fullLayout.scattermode,
gap: fullLayout.scattergap,
groupgap: fullLayout.scattergroupgap
gap: fullLayout.scattergap
};

setGroupPositions(gd, xa, ya, calcTracesVert, opts);
Expand Down
11 changes: 0 additions & 11 deletions src/traces/scatter/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,5 @@ module.exports = {
'adjacent location coordinates.',
'Defaults to `bargap`.'
].join(' ')
},
scattergroupgap: {
valType: 'number',
min: 0,
max: 1,
dflt: 0,
editType: 'calc',
description: [
'Sets the gap (in plot fraction) between scatter points of',
'the same location coordinate.'
].join(' ')
}
};
1 change: 0 additions & 1 deletion src/traces/scatter/layout_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ module.exports = function(layoutIn, layoutOut) {

if(layoutOut.scattermode === 'group') {
coerce('scattergap', groupBarmode ? layoutOut.bargap : 0.2);
coerce('scattergroupgap');
}
};
8 changes: 0 additions & 8 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45315,14 +45315,6 @@
"min": 0,
"valType": "number"
},
"scattergroupgap": {
"description": "Sets the gap (in plot fraction) between scatter points of the same location coordinate.",
"dflt": 0,
"editType": "calc",
"max": 1,
"min": 0,
"valType": "number"
},
"scattermode": {
"description": "Determines how scatter points at the same location coordinate are displayed on the graph. With *group*, the scatter points are plotted next to one another centered around the shared location. With *overlay*, the scatter points are plotted over one another, you might need to reduce *opacity* to see multiple scatter points.",
"dflt": "overlay",
Expand Down