Skip to content

Add marker.cornerradius to treemap #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 11 commits into from
Dec 21, 2022
Merged

Add marker.cornerradius to treemap #6351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8495ea4
expose fillet attribute for treemap
emilykl Oct 19, 2022
f55d7db
expose fillet attribute for icicle
emilykl Oct 19, 2022
8333f2b
update image tests for new attribute
emilykl Oct 19, 2022
62dc7ea
update schema file
emilykl Oct 21, 2022
1ebc8c4
Add jasmine test for restyling treemap marker.fillet attribute
archmoj Oct 21, 2022
c61aecc
add jasmine tests for icicle restyling marker.fillet
emilykl Oct 24, 2022
7b6e278
add draftlogs file
emilykl Oct 24, 2022
66ca5f9
revise attribute name and do not add it to icicle
archmoj Nov 17, 2022
81fa893
improve attribute description
archmoj Nov 17, 2022
369f817
FILLET > cornerradius
archmoj Nov 17, 2022
a814408
take into account pad when text is present
archmoj Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve attribute description
  • Loading branch information
@archmoj
archmoj committed Nov 17, 2022
commit 81fa89355f834a15db6dfeecdf8f6b74ee9fb702
4 changes: 1 addition & 3 deletions src/traces/treemap/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,16 +144,14 @@ module.exports = {
cornerradius: {
valType: 'number',
min: 0,
// max: 10, // TODO: Do we need a max?
dflt: 0,
editType: 'plot',
description: [
'Sets the rounding of corners (in px).'
'Sets the maximum rounding of corners (in px).'
].join(' ')
},

editType: 'calc',

},
colorScaleAttrs('marker', {
colorAttr: 'colors',
Expand Down
4 changes: 2 additions & 2 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34113,7 +34113,7 @@
"valType": "string"
},
"cornerradius": {
"description": "Sets the rounding of corners (in px).",
"description": "Sets the maximum rounding of corners (in px).",
"dflt": 0,
"editType": "plot",
"min": 0,
Expand Down Expand Up @@ -69179,7 +69179,7 @@
"valType": "string"
},
"cornerradius": {
"description": "Sets the rounding of corners (in px).",
"description": "Sets the maximum rounding of corners (in px).",
"dflt": 0,
"editType": "plot",
"min": 0,
Expand Down