-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Mult axis formatting #6334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Mult axis formatting #6334
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
e4a81e3
Add shift parameter and set defaults accordingly
hannahker de79261
Set defaults
hannahker 18f21cb
Simplify logic
hannahker 0e85776
Fix coercion logic
hannahker ba0c587
Include shift logic during drawing
hannahker 2731eb8
Add baseline image and fix syntax for tests
hannahker c535c56
Fixes for tests
hannahker a8fcadc
Update plot schema
hannahker 0f93feb
Fix syntax
hannahker d79ef96
pass axShifts in opts & bypass undefined axShifts
archmoj b1d10c5
Shift axis line if applicable
hannahker 3fa0f0c
Add new mocks and set default position according to overlaying domain
hannahker 50fe1fd
Shift axes according to overlaying group
hannahker 1984b7e
Clean up code to increment shifts
hannahker b9c77b8
Set shift valType to any
hannahker 8a420d6
Add jasmine tests for defaults and update baselines
hannahker 8d0c9eb
Fix syntax
hannahker 5528a35
Enable numeric shift values
hannahker fbdc5a4
Fix zerolines bug
hannahker d742cc5
Fix logic in shift values
hannahker c2ba6b0
Push axis to layout in jasmine test and add baseline
hannahker cb66b12
Fix syntax
hannahker 38f17b2
Add more jasmine tests for defaults relative to shift
hannahker bbf682f
Fix bugs with scroll and drag interactions
hannahker 0175979
Simplify syntax
hannahker 7a1c9d8
Adjust mock to have variable axis sizes
hannahker 5aee58b
Set axis shift after drawing
hannahker fd098a9
Push out axes by estimated depth
hannahker 79c2c74
Move axis line drawing to axes file
hannahker bc9bfa2
Avoid drawing lines when not necessary
hannahker 5ffbdd2
Calculate depth without axis titles
hannahker 168b3db
Remove arrow functions
hannahker 472efb9
Fix failing dragbox test and mock validation
hannahker 0c33429
Add hard coded padding and titles to axes
hannahker 83e7f82
Remove whitespace
hannahker 6e71f53
Replace mocks
hannahker 28eadb0
Merge pull request #6357 from plotly/mult-axis-formatting-depth
hannahker 6d5ecb5
Revert changes to axis line drawing
hannahker 2b951fd
Merge branch 'master' into mult-axis-formatting
hannahker f97f27c
Properly account for axis title positioning
hannahker de4dd05
Fix syntax and add updated mocks
hannahker 38d3e71
Make sure that the axes redraw with dragbox still works
hannahker 683d0f3
Account for case where title fits inside axis labels
hannahker eca5d4f
Simplify syntax with feedback
hannahker b84f89d
Update baselines with smaller padding
hannahker 5f2240f
Add jasmine test for axis positioning
hannahker 81b661f
Fix syntax
hannahker ec1f855
Simplify function call
hannahker e56020d
Redraw if needed based on shift param
hannahker b8bfab5
Add baseline for new mock and fix syntax
hannahker b41678c
Merge branch 'master' into mult-axis-formatting
hannahker 6064e5a
Rename redraw function and remove export
hannahker 085c2b7
Adjust API to have both autoshift and shift params
hannahker 49ddf46
Update plot schema and baseline
hannahker a45eca6
Adjust logic for default setting
hannahker 56605bc
Adjust text for docs
hannahker 5506ed4
Improve documentation and simplify syntax
hannahker 61c2889
set ax._fullDepth only when needed
archmoj d06bc6d
simplify autoshift checks
archmoj bab8020
adjust description keys and values
archmoj 09b5d0c
no shift when zero
archmoj b89f59a
do not add autoshift and shift to xaxis for now
archmoj 948809b
adjust asterisks for new attributes shift & autoshift
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Shift axis line if applicable
- Loading branch information
commit b1d10c574fd69fc875c3a5a538c1018e7d5b962b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.