Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long URLs in outbound breakdown #3183

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix long URLs in outbound breakdown #3183

merged 3 commits into from
Jul 24, 2023

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Jul 24, 2023 •
edited
Loading

Changes

Fixes: #3158

Before:

image

After:

image

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@aerosol aerosol requested a review from vinibrsl July 24, 2023 10:17
@bundlemon
Copy link

bundlemon bot commented Jul 24, 2023 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ static/js/dashboard.js
 319KB (+435B +0.13%) -
Unchanged files (6)
Status Path Size Limits
✅ static/css/app.css
 492.34KB -
✅ static/js/app.js
 40.11KB -
✅ static/js/embed.host.js
 5.58KB -
✅ static/js/embed.content.js
 5.08KB -
✅ tracker/js/plausible.js
 742B -
✅ static/js/applyTheme.js
 314B -

Total files change +435B +0.05%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@aerosol aerosol requested a review from RobertJoonas July 24, 2023 10:21
vinibrsl
vinibrsl approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@vinibrsl vinibrsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

@aerosol aerosol merged commit b606fc1 into master Jul 24, 2023
@aerosol aerosol deleted the trim-long-urls branch July 24, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinibrsl vinibrsl vinibrsl approved these changes

@RobertJoonas RobertJoonas Awaiting requested review from RobertJoonas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outbound Click goal URLs are not truncated
2 participants
@aerosol @vinibrsl