-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): support short-option groups #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Feb 5, 2022
shadowspawn
reviewed
Feb 5, 2022
shadowspawn
reviewed
Feb 5, 2022
shadowspawn
approved these changes
Feb 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of non-blocking suggestions.
@shadowspawn take a look at the updated |
shadowspawn
reviewed
Feb 5, 2022
shadowspawn
reviewed
Feb 5, 2022
shadowspawn
reviewed
Feb 5, 2022
Co-authored-by: John Gee <[email protected]>
Co-authored-by: John Gee <[email protected]>
Co-authored-by: John Gee <[email protected]>
shadowspawn
reviewed
Feb 6, 2022
LGTM again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for supporting short option groups that is quite simple (which I like), and at the same time agrees with an edge-case documented in
yargs-parser
-- which make me think it's a reasonable approach (I at least haven't noticed many folks complain about this edge-case in the past).The implementation
Quite simply,
-foo
expands out to-f
,-o
,-o
, and each individual value is handled by the next step in the parser.The interesting edge-case of this is that if
withValue
is configured for the terminal value in the short option list, and the short-option list is followed by a positional, it will be consumed:As mentioned, this behavior agrees with unit tests in
yargs-parser
:TODO: document this decision in README.Fixes #2