feat: support single dash as positional #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
changed the title
Eomm
approved these changes
Jan 29, 2022
ljharb
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do "something" with a single dash, and I think it is appropriate to treat it as a positional.
The canonical use is as per the README, a shortcut for stdin/stdout (depending on context).
(I speculate the README said "no" more because didn't want to commit to how it would be handled than because it shouldn't be a positional.)
For prior art, Commander allows single dash as a positional and also as an option value. This PR only addresses the positional, partly as less likely to be controversial, but also because less likely to conflict with other open Pull Requests!