Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: no subcommands, no worries #47

Merged
merged 1 commit into from
Jan 25, 2022
Merged

docs: no subcommands, no worries #47

merged 1 commit into from
Jan 25, 2022

Conversation

shadowspawn
Copy link
Collaborator

We have lots of problems, but lack of subcommands is not one of them. 🤣

Support for subcommands has not come up in issues or discussion, so not worth continuing to qualify in README. Just saying no covers it fine.

bcoe
bcoe approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It complicates the heck out of the design to support subcommands, I think you should reach for yargs, commander, etc., if you need parsing this complex -- or build something on top of parseargs.

@bcoe bcoe merged commit 61b7f96 into pkgjs:main Jan 25, 2022
@shadowspawn shadowspawn deleted the feature/no-subcommands branch January 25, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadowspawn @bcoe @Eomm