New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make README examples follow eslint rules #35

Merged

bcoe merged 1 commit into pkgjs:main from shadowspawn:feature/examples

Jan 12, 2022

Collaborator

shadowspawn commented Jan 10, 2022

Style suggestion, no functional changes.

change require to work with current package name (for now)
change examples to follow eslint rules
move example "output" into comments, so js block is valid javascript

(The original examples may have had the node REPL in mind with the "output" format, but I found that a bit confusing.)


          Make README examples follow eslint rules

afcd34b

bcoe approved these changes

View reviewed changes

bcoe merged commit 10a8b20 into pkgjs:main

shadowspawn deleted the feature/examples branch

January 12, 2022 20:49

shadowspawn mentioned this pull request

refactor: use primordials #37

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet