Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/session: add binding operations to CRUCIAL OPERATION log #57483

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 19, 2024

What problem does this PR solve?

Issue Number: close #57482

Problem Summary:

What changed and how does it work?

Add create/drop/set bindings to CRUCIAL OPERATION log.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • create a cluster
  • run create/drop/set binding statements
  • check CRUCIAL OPERATION log, e.g.
[2024/11/19 11:19:54.383 +08:00] [INFO] [session.go:4109] ["CRUCIAL OPERATION"] [conn=2097154] [schemaVersion=55] [cur_db=test] [sql="create global binding using select 1"] [user=root@%]
[2024/11/19 11:21:19.221 +08:00] [INFO] [session.go:4109] ["CRUCIAL OPERATION"] [conn=2097154] [schemaVersion=55] [cur_db=test] [sql="set binding disabled for select 1"] [user=root@%]
[2024/11/19 11:22:18.493 +08:00] [INFO] [session.go:4109] ["CRUCIAL OPERATION"] [conn=2097154] [schemaVersion=55] [cur_db=test] [sql="drop global binding for select 1"] [user=root@%]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
@jackysp jackysp requested a review from qw4990 November 19, 2024 03:22
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
Copy link

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 03:24:26.774182929 +0000 UTC m=+931428.965051919: ☑️ agreed by qw4990.
  • 2024-11-19 03:29:34.268463271 +0000 UTC m=+931736.459332266: ☑️ agreed by winoros.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5325%. Comparing base (d86a366) to head (485e75b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57483        +/-   ##
================================================
+ Coverage   72.8440%   73.5325%   +0.6884%     
================================================
  Files          1672       1672                
  Lines        462716     463399       +683     
================================================
+ Hits         337061     340749      +3688     
+ Misses       104867     101997      -2870     
+ Partials      20788      20653       -135     
Flag Coverage Δ
integration 43.4619% <100.0000%> (?)
unit 72.3758% <100.0000%> (+0.1539%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1122% <ø> (+0.0337%) ⬆️
---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot merged commit 8382fdb into pingcap:master Nov 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need logs for binding operations
3 participants