Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the duplicate offset when pushing topn down across outer join #57471

Merged
merged 3 commits into from
Nov 19, 2024
Merged

planner: fix the duplicate offset when pushing topn down across outer join #57471

merged 3 commits into from
Nov 19, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Nov 18, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #56321, to fix bug caused by #56483

Problem Summary:

The previous pr will cause the final topn's offset to be twice larger than expected.

What changed and how does it work?

When the offset can be pushed down, the original topn can become Sort

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Nov 18, 2024
@winoros winoros changed the title planner: fix the duplicate offset when pushing topn down across outer… planner: fix the duplicate offset when pushing topn down across outer join Nov 18, 2024
@hawkingrei hawkingrei self-requested a review November 18, 2024 14:17
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4176%. Comparing base (140525d) to head (7777c11).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57471        +/-   ##
================================================
+ Coverage   72.8483%   73.4176%   +0.5692%     
================================================
  Files          1672       1672                
  Lines        462661     462889       +228     
================================================
+ Hits         337041     339842      +2801     
+ Misses       104833     102325      -2508     
+ Partials      20787      20722        -65
Flag Coverage Δ
integration 43.3602% <93.3333%> (?)
unit 72.2264% <100.0000%> (+0.0013%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1410% <ø> (+0.0122%) ⬆️
---- 🚨 Try these New Features:

@purelind
Copy link
Contributor

/test pull-integration-python-orm-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 18, 2024

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-integration-python-orm-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

/test pull-integration-python-orm-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 19, 2024

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-integration-python-orm-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

/test pull-integration-python-orm-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 19, 2024

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test fast_test_tiprow_ddlargsv1
  • /test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

  • fast_test_tiprow
  • tidb_parser_test

In response to this:

/test pull-integration-python-orm-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 02:27:01.660532986 +0000 UTC m=+927983.851401976: ☑️ agreed by hawkingrei.
  • 2024-11-19 03:07:12.001413551 +0000 UTC m=+930394.192282562: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 66c7571 into pingcap:master Nov 19, 2024
25 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57486.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2024
Merged
13 tasks
@winoros winoros deleted the fix-topn-down-outer-join branch November 19, 2024 14:02
ti-chi-bot bot pushed a commit that referenced this pull request Nov 19, 2024
@ti-chi-bot
planner: fix the duplicate offset when pushing topn down across outer…
652348b 
… join (#57471) (#57486)

ref #56321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @purelind @ti-chi-bot @hawkingrei @AilinKid