Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Use uint32 as element length in hash join v2 #57458

Merged
merged 6 commits into from
Nov 19, 2024
Merged

executor: Use uint32 as element length in hash join v2 #57458

merged 6 commits into from
Nov 19, 2024

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #53127

Problem Summary:

In TiDB the max row size is 128MB, so for a specific element in any table, it's size should not exceed math.MaxUint32, so this pr use uint32 as the element size in hash join v2

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 18, 2024

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 24 lines in your changes missing coverage. Please review.

Project coverage is 73.4128%. Comparing base (d86a366) to head (cc4706e).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57458        +/-   ##
================================================
+ Coverage   72.8440%   73.4128%   +0.5688%     
================================================
  Files          1672       1672                
  Lines        462716     462795        +79     
================================================
+ Hits         337061     339751      +2690     
+ Misses       104867     102317      -2550     
+ Partials      20788      20727        -61
Flag Coverage Δ
integration 43.3628% <63.8888%> (?)
unit 72.2249% <63.8888%> (+0.0030%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.1091% <ø> (+0.0306%) ⬆️
---- 🚨 Try these New Features:

@windtalker windtalker force-pushed the use_uint32_as_field_length_in_hash_join_v2 branch from 41ab7d7 to c2346ae Compare November 18, 2024 08:53
@windtalker
save work
332afc2 
Signed-off-by: xufei <[email protected]>
@windtalker
fmt
0c8aa15 
Signed-off-by: xufei <[email protected]>
@windtalker
save work
2e3b9fc 
Signed-off-by: xufei <[email protected]>
@windtalker
save work
aa9c2a8 
Signed-off-by: xufei <[email protected]>
@windtalker
fix build
884b513 
Signed-off-by: xufei <[email protected]>
@windtalker
update tests
cc4706e 
Signed-off-by: xufei <[email protected]>
@windtalker windtalker force-pushed the use_uint32_as_field_length_in_hash_join_v2 branch from c2346ae to cc4706e Compare November 19, 2024 01:06
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
xzhangxian1008
xzhangxian1008 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 03:10:14.881294702 +0000 UTC m=+930577.072163698: ☑️ agreed by wshwsh12.
  • 2024-11-19 06:48:57.002183404 +0000 UTC m=+943699.193052423: ☑️ agreed by xzhangxian1008.

@xzhangxian1008
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@xzhangxian1008
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit ac90676 into pingcap:master Nov 19, 2024
24 checks passed
@windtalker windtalker deleted the use_uint32_as_field_length_in_hash_join_v2 branch November 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @xzhangxian1008 @wshwsh12