Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Set minimum cost to avoid parent multiplication cost discrepancies #56387

Merged
merged 13 commits into from
Sep 29, 2024
Merged

planner: Set minimum cost to avoid parent multiplication cost discrepancies #56387

merged 13 commits into from
Sep 29, 2024

Conversation

terry1purcell
Copy link
Contributor

@terry1purcell terry1purcell commented Sep 28, 2024 •
edited by qw4990
Loading

What problem does this PR solve?

Issue Number: ref #55126

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/planner SIG: Planner labels Sep 28, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 28, 2024

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3437%. Comparing base (3922a4b) to head (af26ec6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56387        +/-   ##
================================================
+ Coverage   73.3869%   75.3437%   +1.9568%     
================================================
  Files          1623       1623                
  Lines        447156     447197        +41     
================================================
+ Hits         328154     336935      +8781     
+ Misses        98887      89739      -9148     
- Partials      20115      20523       +408
Flag Coverage Δ
integration 48.8845% <100.0000%> (?)
unit 72.4725% <100.0000%> (-0.0082%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3072% <ø> (+6.7796%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Sep 28, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2024
@terry1purcell terry1purcell changed the title planner: Set minimum cost to avoid parent multiplying zero child cost planner: Set minimum cost to avoid parent multiplying cost discrepancies Sep 28, 2024
@terry1purcell terry1purcell changed the title planner: Set minimum cost to avoid parent multiplying cost discrepancies planner: Set minimum cost to avoid parent multiplication cost discrepancies Sep 28, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-29 08:52:18.27655921 +0000 UTC m=+172093.696772222: ☑️ agreed by qw4990.
  • 2024-09-29 09:01:00.163783487 +0000 UTC m=+172615.583996499: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 4df3389 into pingcap:master Sep 29, 2024
23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56411.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 29, 2024
@terry1purcell @ti-chi-bot
This is an automated cherry-pick of pingcap#56387
d1bbc41 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 29, 2024
@terry1purcell @ti-chi-bot
This is an automated cherry-pick of pingcap#56387
106b64f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56412.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2024
Merged
13 tasks
EricZequan pushed a commit to EricZequan/tidb that referenced this pull request Sep 29, 2024
@terry1purcell @EricZequan
planner: Set minimum cost to avoid parent multiplication cost discrep…
c706c02 
…ancies (pingcap#56387)

ref pingcap#55126
@terry1purcell terry1purcell deleted the zerocost branch September 29, 2024 10:15
ti-chi-bot bot pushed a commit that referenced this pull request Sep 30, 2024
@ti-chi-bot
planner: Set minimum cost to avoid parent multiplication cost discrep…
cceec97 
…ancies (#56387) (#56412)

ref #55126
ti-chi-bot bot pushed a commit that referenced this pull request Nov 12, 2024
@ti-chi-bot
planner: Set minimum cost to avoid parent multiplication cost discrep…
2709f89 
…ancies (#56387) (#56411)

ref #55126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terry1purcell @ti-chi-bot @hawkingrei @qw4990