infoschema: add more tests for infoschema predicate#55591
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom Aug 28, 2024
Merged
infoschema: add more tests for infoschema predicate#55591ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
ti-chi-bot
bot
added
do-not-merge/work-in-progress
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
CbcWestwolf
force-pushed
the
test_infoschema_predicate
branch
from
1453c83 to
4cc8a71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55591 +/- ##
================================================
+ Coverage 72.8981% 75.2437% +2.3456%
================================================
Files 1577 1585 +8
Lines 440903 451939 +11036
================================================
+ Hits 321410 340056 +18646
+ Misses 99759 91485 -8274
- Partials 19734 20398 +664
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
size/XXL
Member
Author
|
PTAL @tangenta @wjhuang2016 |
Member
Author
|
/retest |
wjhuang2016
approved these changes
Aug 27, 2024
AilinKid
approved these changes
Aug 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #50305
Problem Summary:
What changed and how does it work?
In
pkg/planner/core/memtable_infoschema_extractor_test.gowe cover testing all combinations of predicates for each infoschema table. It takes tens of seconds to runTestMemtableInfoschemaExtractorCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.