Skip to content

expression, tests: move more test cases to integrationtest#47002

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
Defined2014:move-builtin
Sep 15, 2023
Merged

expression, tests: move more test cases to integrationtest#47002
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
Defined2014:move-builtin

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46679

Problem Summary: Move 59 test cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2023
@tiprow
Copy link

tiprow bot commented Sep 15, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #47002 (5b7e91b) into master (331ae3d) will decrease coverage by 0.5435%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #47002        +/-   ##
================================================
- Coverage   73.2500%   72.7066%   -0.5435%     
================================================
  Files          1335       1356        +21     
  Lines        397728     404032      +6304     
================================================
+ Hits         291336     293758      +2422     
- Misses        87743      91640      +3897     
+ Partials      18649      18634        -15
Flag Coverage Δ
integration 30.3821% <ø> (?)
unit 73.0696% <ø> (-0.1804%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (+0.1179%) ⬆️
parser 84.9699% <ø> (-0.0072%) ⬇️
br 48.5576% <ø> (-4.3688%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 15, 2023
@hawkingrei hawkingrei requested a review from xhebox September 15, 2023 08:25
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 07:42:50.14221076 +0000 UTC m=+244136.109798795: ☑️ agreed by hawkingrei.
  • 2023-09-15 09:58:21.812953164 +0000 UTC m=+252267.780541215: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 533de3b into pingcap:master Sep 15, 2023
@Defined2014 Defined2014 deleted the move-builtin branch November 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Defined2014 @hawkingrei @xhebox