Skip to content

disttask: refine add index log#46995

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
ywqzzy:fix_add_index_log
Sep 15, 2023
Merged

disttask: refine add index log#46995
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
ywqzzy:fix_add_index_log

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary:

What is changed and how it works?

Refine some typo in log.
Add metric for read index executor.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2023
@tiprow
Copy link

tiprow bot commented Sep 14, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #46995 (a6b498b) into master (ae3f595) will decrease coverage by 0.5105%.
Report is 4 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46995        +/-   ##
================================================
- Coverage   73.2676%   72.7572%   -0.5105%     
================================================
  Files          1335       1356        +21     
  Lines        397716     404595      +6879     
================================================
+ Hits         291397     294372      +2975     
- Misses        87685      91603      +3918     
+ Partials      18634      18620        -14
Flag Coverage Δ
integration 28.8874% <0.0000%> (?)
unit 73.2803% <0.0000%> (+0.0127%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9771% <ø> (+0.0021%) ⬆️
br 48.5834% <ø> (-4.3451%) ⬇️

zimulala
zimulala approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [wjhuang2016,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-14 16:32:18.718607925 +0000 UTC m=+189504.686195960: ☑️ agreed by wjhuang2016.
  • 2023-09-15 02:04:34.239390169 +0000 UTC m=+223840.206978220: ☑️ agreed by zimulala.

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test a6b498b link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 15, 2023

/retest

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

hawkingrei commented Sep 15, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4a86bb4 into pingcap:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ywqzzy @hawkingrei @zimulala @wjhuang2016