Skip to content

linter: enable too many tests#46988

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
hawkingrei:ets
Sep 14, 2023
Merged

linter: enable too many tests#46988
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
hawkingrei:ets

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 14, 2023

What problem does this PR solve?

Issue Number: ref #40786

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 14, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2023
@hawkingrei hawkingrei requested a review from xhebox September 14, 2023 10:36
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hi-rustin,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei hawkingrei requested a review from 0xPoe September 14, 2023 10:36
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-14 10:32:57.777743054 +0000 UTC m=+167943.745331088: ☑️ agreed by lance6716.
  • 2023-09-14 10:36:31.739700297 +0000 UTC m=+168157.707288347: ☑️ agreed by hi-rustin.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #46988 (a598b69) into master (a7617f3) will decrease coverage by 0.6268%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46988        +/-   ##
================================================
- Coverage   73.3129%   72.6861%   -0.6268%     
================================================
  Files          1332       1354        +22     
  Lines        397608     403975      +6367     
================================================
+ Hits         291498     293634      +2136     
- Misses        87498      91687      +4189     
- Partials      18612      18654        +42     
Flag Coverage Δ
integration 28.6834% <ø> (?)
unit 73.2294% <ø> (-0.0835%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (-0.0532%) ⬇️
parser 84.9803% <ø> (-0.0216%) ⬇️
br 48.5613% <ø> (-4.3470%) ⬇️

@hawkingrei
Copy link
Member Author

/retest

Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei changed the title linter: enable too many tests for session linter: enable too many tests Sep 14, 2023
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9bfa176 into pingcap:master Sep 14, 2023
@hawkingrei hawkingrei deleted the ets branch November 4, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants