executor: add some comments and fix typos#46987
Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom Sep 14, 2023
Merged
executor: add some comments and fix typos#46987ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
0xPoe
added
the
skip-issue-check
ti-chi-bot
bot
added
release-note-none
hawkingrei
approved these changes
Sep 14, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46987 +/- ##
================================================
- Coverage 73.2364% 72.6218% -0.6147%
================================================
Files 1332 1357 +25
Lines 397608 404855 +7247
================================================
+ Hits 291194 294013 +2819
- Misses 87769 92168 +4399
- Partials 18645 18674 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
qw4990
approved these changes
Sep 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Member
|
/retest |
4 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
Member
Author
|
/retest |
Member
|
/retest |
0xPoe
force-pushed
the
rustin-patch-comments
branch
from
4dd01f5 to
5ceaed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.