Skip to content

model: set collation and charset for ExtraPhysTblIDCol and ExtraPartitionIDCol#46972

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Defined2014:fix-warn-log
Sep 15, 2023
Merged

model: set collation and charset for ExtraPhysTblIDCol and ExtraPartitionIDCol#46972
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Defined2014:fix-warn-log

Conversation

@Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Run TestOrderByWithLimit, no warn log like unable to get collation name from collation ID, return default charset and collation instead any more.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 Defined2014 added the skip-issue-check Indicates that a PR no need to check linked issue. label Sep 14, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2023
@tiprow
Copy link

tiprow bot commented Sep 14, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #46972 (3215001) into master (1675fde) will decrease coverage by 0.2038%.
Report is 18 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46972        +/-   ##
================================================
- Coverage   73.3078%   73.1040%   -0.2038%     
================================================
  Files          1331       1360        +29     
  Lines        397592     407820     +10228     
================================================
+ Hits         291466     298133      +6667     
- Misses        87523      91053      +3530     
- Partials      18603      18634        +31
Flag Coverage Δ
integration 29.1966% <ø> (?)
unit 73.7148% <100.0000%> (+0.4070%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.4418% <ø> (+0.3973%) ⬆️
parser 85.2506% <100.0000%> (+0.2594%) ⬆️
br 48.6580% <ø> (-4.2442%) ⬇️

mjonss
mjonss approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just curious why non-character based types needs collations? (Integers, floating point, binary etc.)

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 14, 2023
zimulala
zimulala approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-14 14:11:25.908007804 +0000 UTC m=+181051.875595853: ☑️ agreed by mjonss.
  • 2023-09-15 01:59:53.466101571 +0000 UTC m=+223559.433689606: ☑️ agreed by zimulala.

@Defined2014
Copy link
Contributor Author

Defined2014 commented Sep 15, 2023

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, mjonss, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,mjonss,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 331ae3d into pingcap:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@zimulala zimulala zimulala approved these changes

@mjonss mjonss mjonss approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Defined2014 @hawkingrei @zimulala @mjonss