Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toc: reorganize TiCDC docs in left navigation #19365

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Nov 8, 2024

What is changed, added or deleted? (Required)

  • Moves TiCDC docs from TiDB Tools > TiCDC to the first level in left navigation, to make it easier to find
  • Renames TiCDC to Stream Data in the left navigation
  • Combines the exiting first-level Integrate with the TiCDC docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. labels Nov 8, 2024
@lilin90 lilin90 self-assigned this Nov 8, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2024
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 8, 2024
TOC.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2024
Copy link

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 08:11:03.478063384 +0000 UTC m=+430225.668932381: ☑️ agreed by Oreoxmt.

TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Nov 13, 2024

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90
Copy link
Member Author

lilin90 commented Nov 14, 2024

@benmeadowcroft Thanks for your suggestions! All the suggestions have been accepted via 648fd00. Would you please take another look, and approve this PR if no further comments (Files changed > Review changes > Approve > Submit review)?

Copy link

ti-chi-bot bot commented Nov 19, 2024

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilin90 lilin90 added the lgtm label Nov 19, 2024
@lilin90
Copy link
Member Author

lilin90 commented Nov 19, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit d3738c3 into pingcap:master Nov 19, 2024
9 checks passed
@lilin90 lilin90 deleted the reorg-ticdc-docs branch November 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants