Skip to content

Revise TSO related Grafana monitoring metrics description #18722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 7 commits into from
Aug 28, 2024
Merged

Revise TSO related Grafana monitoring metrics description #18722

ti-chi-bot merged 7 commits into from
Aug 28, 2024

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Aug 28, 2024 •
edited
Loading

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 28, 2024
@lilin90 lilin90 self-assigned this Aug 28, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2024
lilin90
lilin90 commented Aug 28, 2024
View reviewed changes
lilin90
lilin90 commented Aug 28, 2024
View reviewed changes
@lilin90 lilin90 requested review from JmPotato and niubell August 28, 2024 06:45
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2024

@JmPotato: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 28, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-28 07:46:43.20717784 +0000 UTC m=+942798.341627971: ☑️ agreed by qiancai.

@lilin90 lilin90 added the lgtm label Aug 28, 2024
@lilin90
Copy link
Member Author

lilin90 commented Aug 28, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 28, 2024
qiancai
qiancai reviewed Aug 28, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot merged commit 19bc75a into pingcap:master Aug 28, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2024

In response to a cherrypick label: new pull request created to branch release-8.2: #18730.

This was referenced Aug 28, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2024

In response to a cherrypick label: new pull request created to branch release-8.3: #18731.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2024

In response to a cherrypick label: new pull request created to branch release-7.1: #18732.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 28, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #18733.

This was referenced Aug 28, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2024

In response to a cherrypick label: new pull request created to branch release-8.0: #18734.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #18735.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 28, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
Revise TSO related Grafana monitoring metrics description (#18722) (#…
392f3cd 
…18731)
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
Revise TSO related Grafana monitoring metrics description (#18722) (#…
7b8b792 
…18730)
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
Revise TSO related Grafana monitoring metrics description (#18722) (#…
a07bc65 
…18733)
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
Revise TSO related Grafana monitoring metrics description (#18722) (#…
1d1ec1c 
…18732)
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
Revise TSO related Grafana monitoring metrics description (#18722) (#…
83256d5 
…18735)
ti-chi-bot bot pushed a commit that referenced this pull request Aug 28, 2024
@ti-chi-bot
Revise TSO related Grafana monitoring metrics description (#18722) (#…
f030036 
…18734)
@lilin90 lilin90 deleted the fix_tso_metrics-18463 branch August 28, 2024 08:47
@Oreoxmt Oreoxmt mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

@niubell niubell Awaiting requested review from niubell

+1 more reviewer

@JmPotato JmPotato JmPotato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lilin90 lilin90

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lilin90 @ti-chi-bot @JmPotato @qiancai