Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix typo for adding layout type #15042

Merged
merged 1 commit into from
Apr 26, 2023
Merged

[Docs] Fix typo for adding layout type #15042

merged 1 commit into from
Apr 26, 2023

Conversation

BlackbitDevs
Copy link
Contributor

It is layout with lowercase L, see

pimcore/bundles/CoreBundle/src/DependencyInjection/PimcoreCoreExtension.php

Line 161 in 770c98c

'config' => $config['objects']['class_definitions']['layout'],

@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited by mcop1
Loading

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Bug fix: check if files are affected that were moved to a bundle - create a PR there if applicable
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@mcop1 mcop1 self-assigned this Apr 26, 2023
@mcop1 mcop1 added the Bug label Apr 26, 2023
@mcop1 mcop1 added this to the 10.5.21 milestone Apr 26, 2023
@mcop1
Copy link
Contributor

mcop1 commented Apr 26, 2023

Thanks 👍

@mcop1 mcop1 merged commit a5b86f3 into pimcore:10.5 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Bug
Projects
None yet
Milestone
10.5.21
Development

Successfully merging this pull request may close these issues.
2 participants
@BlackbitDevs @mcop1