TextArea.ScrollToStart/End fixes #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
TextArea.ScrollToStart()andScrollToEnd()consistent across platforms, and now horizontally scrolls to the left, center, or right depending on the currentTextAlignmentfor the control.This also fixes a bug on Mac where it would not scroll properly after changing the text, so it ensures the text has had its layout pass before scrolling.
On Mac/Gtk it previously scrolled to wherever the last/first character was, whereas on WinForms/WPF it would always set the horizontal scroll to 0/left.
This should also theoretically work better for RTL if enabled natively.