ASTCache: use a double weak dictionary #13379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test passed, but the code is ugly. Some stats (see #13368 for other numbers)
So the numbers are lower but are not that reliable: elements are collected on future GC, and it seems that |
jecisc
added
Status: Waiting for other PR
Status: Tests passed please review!
and removed
Status: Waiting for other PR
labels
jecisc
approved these changes
Apr 11, 2023
jecisc
added
Status: Reviewed and Ready to Integrate
and removed
Status: Tests passed please review!
labels
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13378 for the refactor. Look at the last commit only.
Instead of a
WeakIdentityKeyDictionary, that keep forever uninteresting AST.Use a
WeakIdentityKeyWeakValueDictionary! But because this class does not exist, and because I do not want to implement is (and because ephemerons are coming), I just simulate it with aWeakIdentityKeyDictionaryof single-cellWeakArrays, and a special loop to remove garbage collected value.For the rationale, look at #13371 (comment)