Skip to content

Faulty code: various undeclared cleanups #13248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2023
Merged

Faulty code: various undeclared cleanups #13248

merged 4 commits into from
Apr 2, 2023

Conversation

privat
Copy link
Contributor

@privat privat commented Apr 2, 2023

Some cleanup extracted from #13244 that I think are good as is

Summary

  • fix notice description in early boostrap (fewer features available)
  • Remove undeclared variables in some boostrap script by splitting them into two chunks
  • add some permitFaulty in tests that use undeclared variables

@MarcusDenker MarcusDenker merged commit eda32cd into pharo-project:Pharo12 Apr 2, 2023
@privat privat mentioned this pull request Apr 3, 2023
Open
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

Assignees
No one assigned
Labels
Status: Tests passed please review!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@privat @MarcusDenker