Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faulty compiler: new CodeError class #13029

Merged
merged 10 commits into from
Mar 17, 2023
Merged

Faulty compiler: new CodeError class #13029

merged 10 commits into from
Mar 17, 2023

Conversation

privat
Copy link
Contributor

@privat privat commented Mar 16, 2023

This PR adds a new error super class for syntactic and semantic errors: CodeError.

The changes are rather brutal since:

  • SyntaxErrorNotification become an Error (instead of a notification). The name stays unchanged for now.
  • OCSemanticError is stripped of its responsibility to report error on the UI (yes, it was this bad).

Note: OCSemanticWarning, especially OCUndeclaredVariableWarning are let untouched (yet!)

Let's see if CI thinks this to too much change to handle...

@privat
Copy link
Contributor Author

privat commented Mar 16, 2023

tests are ok, except windows. But I added more commits for some related cleanup

@MarcusDenker MarcusDenker merged commit 22471b2 into pharo-project:Pharo12 Mar 17, 2023
@privat privat mentioned this pull request Mar 21, 2023
Open
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusDenker MarcusDenker MarcusDenker approved these changes

Assignees
No one assigned
Labels
Status: Tests passed please review! Version: Pharo 12
Projects
Pharo Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@privat @MarcusDenker