Improve OCUndeclaredVariableWarning>>declareTempAndPaste #12978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and use a rather ugly hack instead
|
Thanks for cleaning this prehistorical code (and it was not the original compiler but a "new one" but with left over of other hacks). |
|
Yes, and the whole idea (to fix the code during exception handling) is just plain bad. |
|
please do not submit more enhancements until we open P12 development. |
|
@estebanlm yes, it is intended pf P12. Unfortunately, I'm not able to set the pharo12 tag myself. |
MarcusDenker
approved these changes
Mar 14, 2023
MarcusDenker
approved these changes
Mar 15, 2023
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low-hanging fruit. A small cleanup of declareTempAndPaste that reduces the hackish level a little