Improve faulty compilation - semantic error #12919
Conversation
|
Broken build, not related to this change:
|
privat
force-pushed
the
improve-faulty-compilation-semantic-error
branch
from
8417bd7 to
181e142
Compare
|
So, are comments useful if merged without answer ??? |
|
@demarey where is the standard/style guide about protocols/categories on Pharo? I did not find one. Personally, I prefer when methods are grouped by concerns, but if there are some rules I can follow them. |
|
@privat You have some rules encoded in the Method classifier. Foe example, you can see methods starting with
|
|
@demarey thank you for the pointer. Although a list of heuristics on substrings to determinate some default protocol is not what I envisioned for "rule" or a "standard" :) |
This PR extends AST API with basic methods for semantic error
addError:to let compiler add semantic error information on NodeisErrorto let AST user knows if the node is erroneousisFaultyis extended to encompass both syntax error (RBParseErrorNode) and other kind of errors (isError)The internal implementation is to use a node property
#error.Currently, (I'm not aware of a plan to add more semantic error, so this is not the better term) there seems to be only 2 semantic errors: unwritable variable (for some reason read-only and reserved are distinguished) and too much argument (for block and methods), the latter was moved from backend to the semantic analysis (because the whole point of semantic analysis is to get these errors before compilation).
The status of undeclared variable as error is unclear and seems to depend on UI related stuff (and possibly the humidity level).
The code is deliberately written as simple as possible, first attempts were too much complex for a limited gain.
A possible future improvement could be to unify and reify errors and warnings (strings are poor).
Maybe look at how critiques does the deal.
UI related concerns (like nice icons in the icon bar) will be added in a future PR.
Another question is how much people like (or rely) on the current semantic error/warnings exception hierarchy (
OCSemanticError,OCStoreIntoReadOnlyVariableError,OCStoreIntoReservedVariableError,OCSemanticWarning,OCShadowVariableWarning,OCUndeclaredVariableWarning)